From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Hurley <peter@hurleysoftware.com>
Subject: Re: [PATCH 03/15] tty: audit: Remove icanon mode from call chain
Date: Mon, 16 Nov 2015 08:25:38 -0500
Message-ID: <5649D952.8000003@hurleysoftware.com>
References: <1447207560-16410-1-git-send-email-peter@hurleysoftware.com>
	<1447207560-16410-4-git-send-email-peter@hurleysoftware.com>
	<20151112191032.GA24011@madcap2.tricolour.ca>
	<5644EF6D.2030103@hurleysoftware.com>
	<20151113021559.GB24011@madcap2.tricolour.ca>
	<56454A7B.2030203@hurleysoftware.com>
	<20151113032857.GC24011@madcap2.tricolour.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
Received: from mx1.redhat.com (ext-mx07.extmail.prod.ext.phx2.redhat.com
	[10.5.110.31])
	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP
	id tAGDPjYY021759
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=NO)
	for <linux-audit@redhat.com>; Mon, 16 Nov 2015 08:25:45 -0500
Received: from mail-ig0-f177.google.com (mail-ig0-f177.google.com
	[209.85.213.177])
	by mx1.redhat.com (Postfix) with ESMTPS id 67235C04FF81
	for <linux-audit@redhat.com>; Mon, 16 Nov 2015 13:25:44 +0000 (UTC)
Received: by igl9 with SMTP id 9so56831026igl.0
	for <linux-audit@redhat.com>; Mon, 16 Nov 2015 05:25:43 -0800 (PST)
In-Reply-To: <20151113032857.GC24011@madcap2.tricolour.ca>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-audit@redhat.com, Jiri Slaby <jslaby@suse.cz>
List-Id: linux-audit@redhat.com

On 11/12/2015 10:28 PM, Richard Guy Briggs wrote:
> On 15/11/12, Peter Hurley wrote:
>> On 11/12/2015 09:15 PM, Richard Guy Briggs wrote:
>>> On 15/11/12, Peter Hurley wrote:
>>>> On 11/12/2015 02:10 PM, Richard Guy Briggs wrote:
>>>>> On 15/11/10, Peter Hurley wrote:
>>>>>> The tty termios bits cannot change while n_tty_read() is in the
>>>>>> i/o loop; the termios_rwsem ensures mutual exclusion with termios
>>>>>> changes in n_tty_set_termios(). Check L_ICANON() directly and
>>>>>> eliminate icanon parameter.
>>>>>>
>>>>>> NB: tty_audit_add_data() => tty_audit_buf_get() => tty_audit_buf_alloc()
>>>>>> is a single path; ie., tty_audit_buf_get() and tty_audit_buf_alloc()
>>>>>> have no other callers.
>>>>>
>>>>> Which tree is this based on?  I don't see where the first chunk applies.
>>>>
>>>> 4.3
>>>>
>>>> but this series requires a -stable fix [1] posted earlier but not in any
>>>> tree yet, which I noted in the cover-letter (was easy to overlook).
>>>
>>> Ok, found it.  It appears to also depend on "n_tty: Uninline
>>> tty_copy_to_user()" [2] which I didn't see mentioned and can't find
>>> upstream.
>>
>> Sorry, my bad; I overlooked that dependency.
> 
> Looks like it also depends on "n_tty: Clarify copy_from_read_buf()" [3].

<sigh>

> Any more we should know about?  Or should we just wait for GKH's tree?

Yes, let's just wait until the dependencies are in Greg's tree.
I'll resend the series as v2 then.

Regards,
Peter Hurley



>>>  Is that in an upstream tree?
>>
>> Not yet. That will end up in Greg's tty-next tree sometime shortly after
>> the merge window closes.
>>
>>>> [1] https://lkml.org/lkml/2015/11/8/133
>>>
>>> [2] https://lkml.org/lkml/2015/11/8/146
> 
> [3] https://lkml.org/lkml/2015/11/8/145
> 
> - RGB