From mboxrd@z Thu Jan  1 00:00:00 1970
From: Steve Grubb <sgrubb@redhat.com>
Subject: Re: [PATCH] integrity: get comm using lock to avoid race in string
	printing
Date: Wed, 02 Apr 2014 14:00:23 -0400
Message-ID: <6292885.20TorKeRiK@x2>
References: <11db0d126ef0ec7506ef5cb6f2f21c926d206436.1396455228.git.rgb@redhat.com>
	<1396460387.20325.22.camel@dhcp-9-2-203-236.watson.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <1396460387.20325.22.camel@dhcp-9-2-203-236.watson.ibm.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: Richard Guy Briggs <rgb@redhat.com>, linux-security-module@vger.kernel.org, linux-audit@redhat.com, linux-kernel@vger.kernel.org
List-Id: linux-audit@redhat.com

Hello Mimi,

On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote:
> This change is already being upstreamed as commit 73a6b44 "Integrity:
> Pass commname via get_task_comm()".

While I was looking at Richard's patch, I noticed a few places where cause and 
op are logged and the string isn't tied together with a _ or -. These are in 
ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are 
these fixed upstream? Or should a patch be made?

Thanks,
-Steve