From mboxrd@z Thu Jan  1 00:00:00 1970
From: Miloslav =?utf-8?Q?Trma=C4=8D?= <mitr@redhat.com>
Subject: Re: pam_tty_audit icanon log switch
Date: Thu, 18 Apr 2013 15:31:36 -0400 (EDT)
Message-ID: <669386482.3913087.1366313496573.JavaMail.root@redhat.com>
References: <20130322054636.GA18911@madcap2.tricolour.ca>
	<1677270682.17361178.1365713025068.JavaMail.root@redhat.com>
	<20130418191430.GA4112@madcap2.tricolour.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <linux-audit-bounces@redhat.com>
In-Reply-To: <20130418191430.GA4112@madcap2.tricolour.ca>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-audit>
List-Post: <mailto:linux-audit@redhat.com>
List-Help: <mailto:linux-audit-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-audit>,
	<mailto:linux-audit-request@redhat.com?subject=subscribe>
Sender: linux-audit-bounces@redhat.com
Errors-To: linux-audit-bounces@redhat.com
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Linux-Audit Mailing List <linux-audit@redhat.com>
List-Id: linux-audit@redhat.com

Hello,

----- Original Message -----
> Full replacement patch:

I'm still convinced that icanon is not the correct condition, see https://www.redhat.com/archives/linux-audit/2013-March/msg00052.html .


> diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
> index 9f096f1..a863669 100644
> --- a/include/uapi/linux/audit.h
> +++ b/include/uapi/linux/audit.h
> @@ -369,7 +369,8 @@ struct audit_status {
>  };
>  
>  struct audit_tty_status {
> -	__u32		enabled; /* 1 = enabled, 0 = disabled */
> +	__u32		enabled;	/* 1 = enabled, 0 = disabled */
> +	__u32		log_icanon;	/* 1 = enabled, 0 = disabled */
>  };

Also, would it make sense for the user-space API to be more general about expressing the intent ("log passwords")?  I don't know, being precise about the exact effect of the option is also beneficial.
    Mirek