From: Valdis.Kletnieks@vt.edu
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, sgrubb@redhat.com, eparis@parisplace.org,
pmoore@redhat.com
Subject: Re: [PATCH] audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb
Date: Fri, 19 Dec 2014 19:52:59 -0500 [thread overview]
Message-ID: <74385.1419036779@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 18 Dec 2014 23:09:27 -0500." <d261c547d8018a18f2092e1907b06e190162b088.1418947557.git.rgb@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 827 bytes --]
On Thu, 18 Dec 2014 23:09:27 -0500, Richard Guy Briggs said:
> Eric Paris explains: Since kauditd_send_multicast_skb() gets called in
> audit_log_end(), which can come from any context (aka even a sleeping context)
> GFP_KERNEL can't be used. Since the audit_buffer knows what context it should
> use, pass that down and use that.
>
> See: https://lkml.org/lkml/2014/12/16/542
> Reported-by: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> kernel/audit.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/kernel/audit.c b/kernel/audit.c
> index 7b83c55..ce484fb 100644
I was reliably triggering 3-4 BUGs an hour, and with this patch applied I've
gone 9 hours without seeing one.
So feel free to add a Tested-By: when it goes out.
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2014-12-20 0:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 4:09 [PATCH] audit: use supplied gfp_mask from audit_buffer in kauditd_send_multicast_skb Richard Guy Briggs
2014-12-19 23:45 ` Paul Moore
2014-12-20 0:52 ` Valdis.Kletnieks [this message]
2014-12-20 3:51 ` Richard Guy Briggs
2014-12-20 22:30 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74385.1419036779@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=eparis@parisplace.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pmoore@redhat.com \
--cc=rgb@redhat.com \
--cc=selinux@tycho.nsa.gov \
--cc=sgrubb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox