From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Moore Subject: Re: [PATCH] audit: add ppc64 mach support Date: Tue, 02 Dec 2014 18:19:07 -0500 Message-ID: <7591024.l2V3V75FWS@sifl> References: <5400DF80.1080700@suse.de> <2573861.NOhY4taJkb@sifl> <20141202212724.GA12425@madcap2.tricolour.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (ext-mx11.extmail.prod.ext.phx2.redhat.com [10.5.110.16]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id sB2NJCHJ022338 for ; Tue, 2 Dec 2014 18:19:12 -0500 Received: from mail-qa0-f42.google.com (mail-qa0-f42.google.com [209.85.216.42]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id sB2NJAB1004064 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=FAIL) for ; Tue, 2 Dec 2014 18:19:11 -0500 Received: by mail-qa0-f42.google.com with SMTP id j7so9653458qaq.15 for ; Tue, 02 Dec 2014 15:19:10 -0800 (PST) In-Reply-To: <20141202212724.GA12425@madcap2.tricolour.ca> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Richard Guy Briggs Cc: linux-audit@redhat.com List-Id: linux-audit@redhat.com On Tuesday, December 02, 2014 04:27:24 PM Richard Guy Briggs wrote: > On 14/12/02, Paul Moore wrote: > > On Monday, December 01, 2014 03:58:09 PM Tony Jones wrote: > > > Mainline kernel reports ppc64le (per > > > a0588015deab1844261b27a67ae6f5b910fe2830) but there is no matching > > > AUDIT_ARCH_PPC64LE. Eric just pinged me on irc about it. Fix to add > > > it > > > to include/uapi/linux/audit.h shoudld probably go upstream. > > > > Untested, uncompiled too, but beyond the patch below, is there anything > > else we would need in the kernel to enable proper ppc64le support? > > Which kernel are you using? syscall_get_arch() already exists on > powerpc. audit_syscall_entry() lost its first argument recently... That patch was on top of the linux-audit tree, it's based on v3.16 so I imagine there have been some changes upstream over the past few months. > What if it is in compatibility mode? /me shrugs ... that's why I posted it asking for feedback ;) I just wanted to get the ball rolling on a fix. -- paul moore www.paul-moore.com