Re: [PATCH] audit: Add cmdline to taskinfo output

William Roberts
2013-10-30T21:52:47Z

[-- Attachment #1.1: Type: text/plain, Size: 1146 bytes --]

On Wed, Oct 30, 2013 at 2:20 PM, Eric Paris <eparis@redhat.com> wrote:

> I'm like a child wandering into the middle of a movie and having no idea
> what is going on. But...
>

my day to day reality :-P

>
> > The limit is PATH_MAX. You could have an absolute path that
> > uses all available
> > characters.
> >
> > -Steve
> >
> >
> > So looking at PATH_MAX...
> > include/linux/limits.h:12:#define PATH_MAX 4096 /* # chars in a
> > path name including nul */
>
> I seem to recall that PATH_MAX is not really PATH_MAX :) It can be +10
> ish... for the " (deleted)" that gets appended if things are
> unlinked... just something I sorta recall rolling around the back of my
> head and I haven't really any idea if it is applicable here in any
> way...
>
>
I don't think so. The concern is PAGE_SIZE is to big for a message, so lets
pick something else
to truncate the message size on, the suggesting was PATH_MAX which makes
sense
and works in this case.

The patch I have on top of what I submitted so far is to pick PAGE_SIZE or
PATH_MAX, whichever is
smaller.

--
Respectfully,

William C Roberts

[-- Attachment #1.2: Type: text/html, Size: 1840 bytes --]