From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: audit-ptrace patch (untested) Date: Wed, 7 Mar 2007 11:22:24 -0500 (EST) Message-ID: References: <20070305145025.GC19390@devserv.devel.redhat.com> <1173192374.15967.115.camel@moss-spartans.epoch.ncsc.mil> <20070307031308.GA12417@devserv.devel.redhat.com> <1173271948.2050.17.camel@moss-spartans.epoch.ncsc.mil> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: Received: from mx2.redhat.com (mx2.redhat.com [10.255.15.25]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l27GMple020875 for ; Wed, 7 Mar 2007 11:22:51 -0500 Received: from mail8.sea5.speakeasy.net (mail8.sea5.speakeasy.net [69.17.117.10]) by mx2.redhat.com (8.13.1/8.13.1) with ESMTP id l27GMVQa028792 for ; Wed, 7 Mar 2007 11:22:31 -0500 In-Reply-To: <1173271948.2050.17.camel@moss-spartans.epoch.ncsc.mil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com To: Stephen Smalley Cc: Eric Paris , linux-audit@redhat.com List-Id: linux-audit@redhat.com On Wed, 7 Mar 2007, Stephen Smalley wrote: > > audit_free_aux(context); > > kfree(context->filterkey); > > + kfree(context->obj_ctx); > > Technically, this should be: > security_release_secctx(context->obj_ctx, context->ctxlen); > Although that does require keeping the length around, and the rest of > the audit code is already assuming it is just a string (unlike the > original user of these LSM hooks, the labeled IPSEC code). I think these needs to be fixed before merge, as the presence of existing mistakes doesn't justify adding new ones. - James -- James Morris