Re: [PATCH 2.6.19-rc4] audit: support for descriptor pairs (fwd)

Alexander Viro
2006-11-07T18:31:57Z

On Tue, Nov 07, 2006 at 08:58:20AM -0500, Steve Grubb wrote:
> On Tuesday 07 November 2006 08:18, Mark Workman wrote:
> > provide an audit record of the descriptor pair returned by pipe() and
> > socketpair().
>
> Patch looks OK to me. Al, what do you think?

Ehh...
a) why bother with exporting sock_map_... at all?
b) failure exits in socketpair are, AFAICS, botched by the
patch. At the very least, you can get sock_release() done on a socket
that already went through it due to fput(). Please, fix.

I would suggest taking that into sys_socketpair(), actually,
instead of a new helper...