From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 751A0C433F5 for ; Mon, 6 Dec 2021 22:15:31 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-230-mEW9Ae2vNyyp5XAYjCNpvg-1; Mon, 06 Dec 2021 17:15:28 -0500 X-MC-Unique: mEW9Ae2vNyyp5XAYjCNpvg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 54CB586A062; Mon, 6 Dec 2021 22:15:25 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 159511B480; Mon, 6 Dec 2021 22:15:25 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E7A9F4CA9B; Mon, 6 Dec 2021 22:15:24 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1B67MWn6006205 for ; Mon, 6 Dec 2021 02:22:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 281002166B25; Mon, 6 Dec 2021 07:22:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 234282166B26 for ; Mon, 6 Dec 2021 07:22:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1244A802A5E for ; Mon, 6 Dec 2021 07:22:29 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-22-t7PBfrZLNCyyjI65O2bXqA-1; Mon, 06 Dec 2021 02:22:27 -0500 X-MC-Unique: t7PBfrZLNCyyjI65O2bXqA-1 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AC006B80FAE; Mon, 6 Dec 2021 07:13:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2F96C341C4; Mon, 6 Dec 2021 07:13:09 +0000 (UTC) Date: Mon, 6 Dec 2021 09:13:06 +0200 From: Leon Romanovsky To: Leo Yan Subject: Re: [PATCH v1 1/7] pid: Introduce helper task_is_in_root_ns() Message-ID: References: <20211205145105.57824-1-leo.yan@linaro.org> <20211205145105.57824-2-leo.yan@linaro.org> <20211206070358.GC42658@leoy-ThinkPad-X240s> MIME-Version: 1.0 In-Reply-To: <20211206070358.GC42658@leoy-ThinkPad-X240s> X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-loop: linux-audit@redhat.com X-Mailman-Approved-At: Mon, 06 Dec 2021 17:15:10 -0500 Cc: codalist@telemann.coda.cs.cmu.edu, Jan Harkes , Mathieu Poirier , Suzuki K Poulose , Alexander Shishkin , netdev@vger.kernel.org, Balbir Singh , linux-kernel@vger.kernel.org, Eric Paris , coda@cs.cmu.edu, linux-audit@redhat.com, coresight@lists.linaro.org, Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org, Mike Leach X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Dec 06, 2021 at 03:03:58PM +0800, Leo Yan wrote: > Hi Leon, > > On Mon, Dec 06, 2021 at 08:49:01AM +0200, Leon Romanovsky wrote: > > On Sun, Dec 05, 2021 at 10:50:59PM +0800, Leo Yan wrote: > > [...] > > > > +static inline bool task_is_in_root_ns(struct task_struct *tsk) > > > > It is bad that this name doesn't reflect PID nature of this namespace. > > Won't it better to name it task_is_in_init_pid_ns()? > > Yes, task_is_in_init_pid_ns() is more clear. > > Will respin for this. Thank you for suggestion! Thanks > > Leo -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit