From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Gleixner Subject: Re: [PATCH] i386/audit: stop scribbling on the stack frame Date: Mon, 27 Oct 2014 22:18:21 +0100 (CET) Message-ID: References: <1414037043-30647-1-git-send-email-eparis@redhat.com> <20141027023457.GY15532@madcap2.tricolour.ca> <1414418157.24347.1.camel@redhat.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Return-path: In-Reply-To: <1414418157.24347.1.camel@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Eric Paris Cc: Richard Guy Briggs , linux-kernel@vger.kernel.org, przanoni@gmail.com, mingo@kernel.org, hpa@linux.intel.com, hpa@zytor.com, linux-tip-commits@vger.kernel.org, linux-audit@redhat.com List-Id: linux-audit@redhat.com On Mon, 27 Oct 2014, Eric Paris wrote: > My patch was already committed to the -tip urgent branch. I believe any > optimization should be based on that branch, Richard. If you are trying > to wrangle every bit of speed out of this, should you > > push %esi; > push %edi; > CFI_ADJUST_CFA_OFFSET 8 Wrong. You want to use pushl_cfi as you need the CFI adjustment after each modification of esp. > call __audit_syscall_entry > pop; > pop; > CFI_ADJUST_CFA_OFFSET -8 > > Instead of using the pushl_cfi and popl_cfi macros? Wrong again. See above. Aside of that, why do you want to use pop at all? All we care about is adjusting esp, right? Thanks, tglx