From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Morris Subject: Re: [PATCH v2 1/4] seccomp: Separate read and write code for actions_logged sysctl Date: Thu, 3 May 2018 07:01:55 +1000 (AEST) Message-ID: References: <1525276400-7161-1-git-send-email-tyhicks@canonical.com> <1525276400-7161-2-git-send-email-tyhicks@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1525276400-7161-2-git-send-email-tyhicks@canonical.com> Sender: linux-kernel-owner@vger.kernel.org To: Tyler Hicks Cc: linux-kernel@vger.kernel.org, Kees Cook , Andy Lutomirski , Will Drewry , Paul Moore , Eric Paris , Steve Grubb , Jonathan Corbet , linux-audit@redhat.com, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org List-Id: linux-audit@redhat.com On Wed, 2 May 2018, Tyler Hicks wrote: > Break the read and write paths of the kernel.seccomp.actions_logged > sysctl into separate functions to maintain readability. An upcoming > change will need to audit writes, but not reads, of this sysctl which > would introduce too many conditional code paths on whether or not the > 'write' parameter evaluates to true. > > Signed-off-by: Tyler Hicks Reviewed-by: James Morris -- James Morris