* [PATCH] Make IPC mode consistent
@ 2007-05-29 14:39 Steve Grubb
2007-07-16 19:11 ` Klaus Heinrich Kiwi
0 siblings, 1 reply; 2+ messages in thread
From: Steve Grubb @ 2007-05-29 14:39 UTC (permalink / raw)
To: linux-audit
Hi,
The mode fields for IPC records are not consistent. Some are hex, others are
octal. This patch makes them all octal.
Signed-off-by: Steve Grubb <sgrubb@redhat.com>
diff -urp linux-2.6.18.i686.orig/kernel/auditsc.c linux-2.6.18.i686/kernel/auditsc.c
--- linux-2.6.18.i686.orig/kernel/auditsc.c 2007-05-29 10:27:13.000000000 -0400
+++ linux-2.6.18.i686/kernel/auditsc.c 2007-05-29 10:33:07.000000000 -0400
@@ -941,7 +941,7 @@ static void audit_log_exit(struct audit_
case AUDIT_IPC: {
struct audit_aux_data_ipcctl *axi = (void *)aux;
audit_log_format(ab,
- "ouid=%u ogid=%u mode=%x",
+ "ouid=%u ogid=%u mode=%#o",
axi->uid, axi->gid, axi->mode);
if (axi->osid != 0) {
char *ctx = NULL;
@@ -960,7 +960,7 @@ static void audit_log_exit(struct audit_
case AUDIT_IPC_SET_PERM: {
struct audit_aux_data_ipcctl *axi = (void *)aux;
audit_log_format(ab,
- "qbytes=%lx ouid=%u ogid=%u mode=%x",
+ "qbytes=%lx ouid=%u ogid=%u mode=%#o",
axi->qbytes, axi->uid, axi->gid, axi->mode);
break; }
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Make IPC mode consistent
2007-05-29 14:39 [PATCH] Make IPC mode consistent Steve Grubb
@ 2007-07-16 19:11 ` Klaus Heinrich Kiwi
0 siblings, 0 replies; 2+ messages in thread
From: Klaus Heinrich Kiwi @ 2007-07-16 19:11 UTC (permalink / raw)
To: linux-audit
Steve,
Steve Grubb wrote:
> Hi,
>
> The mode fields for IPC records are not consistent. Some are hex, others
> are octal. This patch makes them all octal.
>
> Signed-off-by: Steve Grubb <sgrubb@redhat.com>
Did this patch got through? There is a Novell BZ (#280257 - unfortunatelly
not public at this time) waiting for this to get upstream.
Thanks,
Klaus
>
> diff -urp linux-2.6.18.i686.orig/kernel/auditsc.c
> linux-2.6.18.i686/kernel/auditsc.c
> --- linux-2.6.18.i686.orig/kernel/auditsc.c 2007-05-29 10:27:13.000000000
> -0400
> +++ linux-2.6.18.i686/kernel/auditsc.c 2007-05-29 10:33:07.000000000 -0400
> @@ -941,7 +941,7 @@ static void audit_log_exit(struct audit_
> case AUDIT_IPC: {
> struct audit_aux_data_ipcctl *axi = (void *)aux;
> audit_log_format(ab,
> - "ouid=%u ogid=%u mode=%x",
> + "ouid=%u ogid=%u mode=%#o",
> axi->uid, axi->gid, axi->mode);
> if (axi->osid != 0) {
> char *ctx = NULL;
> @@ -960,7 +960,7 @@ static void audit_log_exit(struct audit_
> case AUDIT_IPC_SET_PERM: {
> struct audit_aux_data_ipcctl *axi = (void *)aux;
> audit_log_format(ab,
> - "qbytes=%lx ouid=%u ogid=%u mode=%x",
> + "qbytes=%lx ouid=%u ogid=%u mode=%#o",
> axi->qbytes, axi->uid, axi->gid, axi->mode);
> break; }
--
.:klaus h kiwi <klausk@br.ibm.com>:.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-07-17 17:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-05-29 14:39 [PATCH] Make IPC mode consistent Steve Grubb
2007-07-16 19:11 ` Klaus Heinrich Kiwi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).