Re: [PATCH -next] audit: remove duplicated include from audit.c

Paul Moore
2018-12-14T17:14:17Z

On Thu, Dec 13, 2018 at 8:33 PM YueHaibing <yuehaibing@huawei.com> wrote:
> On 2018/12/14 7:42, Paul Moore wrote:
> > On Sun, Dec 9, 2018 at 1:25 AM YueHaibing <yuehaibing@huawei.com> wrote:
> >> Remove duplicated include.
> >>
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >> kernel/audit.c | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/kernel/audit.c b/kernel/audit.c
> >> index a0a4544..632d360 100644
> >> --- a/kernel/audit.c
> >> +++ b/kernel/audit.c
> >> @@ -60,7 +60,6 @@
> >> #include <linux/mutex.h>
> >> #include <linux/gfp.h>
> >> #include <linux/pid.h>
> >> -#include <linux/slab.h>
> >
> > As discussed previously, I don't want to remove header files whose
> > declarations are used in the source file. While it may be true that
> > slab.h is included in one of the previously included header files, I
> > like leaving it as an explicit include to help document the dependency
> > and protect us from changes in the other header files.
>
> The slab.h is included twice in audit.c , It like this:

Yes, you're right - my apologies. I mistakenly thought this was a
patch similar to the ones you sent earlier and were rejected; I should
have looked closer at this patch.

Normally I wouldn't merge non-critical stuff at this stage of the
development window, but since this is such a trivial patch, and easily
verified, I'm going to go ahead and merge this into audit/next.

Thank you.

--
paul moore