From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90886C433F5 for ; Wed, 15 Dec 2021 01:40:38 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-251-teatZw9EN2OLsZlWMYs9qw-1; Tue, 14 Dec 2021 20:40:34 -0500 X-MC-Unique: teatZw9EN2OLsZlWMYs9qw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15A09801AAB; Wed, 15 Dec 2021 01:40:30 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC69F7B6F2; Wed, 15 Dec 2021 01:40:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 8134E1809CB8; Wed, 15 Dec 2021 01:40:27 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 1BF1eP5T009934 for ; Tue, 14 Dec 2021 20:40:26 -0500 Received: by smtp.corp.redhat.com (Postfix) id 94BBE40149A6; Wed, 15 Dec 2021 01:40:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast09.extmail.prod.ext.rdu2.redhat.com [10.11.55.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90F35400F3FD for ; Wed, 15 Dec 2021 01:40:24 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC8272BD19F0 for ; Wed, 15 Dec 2021 01:40:24 +0000 (UTC) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-465-EFyqPBf0NCKMS1XSgljlwA-1; Tue, 14 Dec 2021 20:40:22 -0500 X-MC-Unique: EFyqPBf0NCKMS1XSgljlwA-1 Received: from dggeme762-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4JDHbb2HvrzbjPS; Wed, 15 Dec 2021 09:24:43 +0800 (CST) Received: from [10.67.110.176] (10.67.110.176) by dggeme762-chm.china.huawei.com (10.3.19.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.20; Wed, 15 Dec 2021 09:25:01 +0800 Subject: Re: [PATCH] audit: improve robustness of the audit queue handling To: Paul Moore , References: <163942029335.62691.7176083220772477830.stgit@olly> From: cuigaosheng Message-ID: Date: Wed, 15 Dec 2021 09:25:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <163942029335.62691.7176083220772477830.stgit@olly> X-Originating-IP: [10.67.110.176] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme762-chm.china.huawei.com (10.3.19.108) X-CFilter-Loop: Reflected X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 X-MIME-Autoconverted: from quoted-printable to 8bit by lists01.pubmisc.prod.ext.phx2.redhat.com id 1BF1eP5T009934 X-loop: linux-audit@redhat.com X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" CuWcqCAyMDIxLzEyLzE0IDI6MzEsIFBhdWwgTW9vcmUg5YaZ6YGTOgo+IElmIHRoZSBhdWRpdCBk YWVtb24gd2VyZSBldmVyIHRvIGdldCBzdHVjayBpbiBhIHN0b3BwZWQgc3RhdGUgdGhlCj4ga2Vy bmVsJ3Mga2F1ZGl0ZF90aHJlYWQoKSBjb3VsZCBnZXQgYmxvY2tlZCBhdHRlbXB0aW5nIHRvIHNl bmQgYXVkaXQKPiByZWNvcmRzIHRvIHRoZSB1c2Vyc3BhY2UgYXVkaXQgZGFlbW9uLiAgV2l0aCB0 aGUga2VybmVsIHRocmVhZAo+IGJsb2NrZWQgaXQgaXMgcG9zc2libGUgdGhhdCB0aGUgYXVkaXQg cXVldWUgY291bGQgZ3JvdyB1bmJvdW5kZWQgYXMKPiBjZXJ0YWluIGF1ZGl0IHJlY29yZCBnZW5l cmF0aW5nIGV2ZW50cyBtdXN0IGJlIGV4ZW1wdCBmcm9tIHRoZSBxdWV1ZQo+IGxpbWl0cyBlbHNl IHRoZSBzeXN0ZW0gZW50ZXIgYSBkZWFkbG9jayBzdGF0ZS4KPgo+IFRoaXMgcGF0Y2ggcmVzb2x2 ZXMgdGhpcyBwcm9ibGVtIGJ5IGxvd2VyaW5nIHRoZSBrZXJuZWwgdGhyZWFkJ3MKPiBzb2NrZXQg c2VuZGluZyB0aW1lb3V0IGZyb20gTUFYX1NDSEVEVUxFX1RJTUVPVVQgdG8gSFovMTAgYW5kIHR3 ZWFrcwo+IHRoZSBrYXVkaXRkX3NlbmRfcXVldWUoKSBmdW5jdGlvbiB0byBiZXR0ZXIgbWFuYWdl IHRoZSB2YXJpb3VzIGF1ZGl0Cj4gcXVldWVzIHdoZW4gY29ubmVjdGlvbiBwcm9ibGVtcyBvY2N1 ciBiZXR3ZWVuIHRoZSBrZXJuZWwgYW5kIHRoZQo+IGF1ZGl0IGRhZW1vbi4gIFdpdGggdGhpcyBw YXRjaCwgdGhlIGJhY2tsb2cgbWF5IHRlbXBvcmFyaWx5IGdyb3cKPiBiZXlvbmQgdGhlIGRlZmlu ZWQgbGltaXRzIHdoZW4gdGhlIGF1ZGl0IGRhZW1vbiBpcyBzdG9wcGVkIGFuZCB0aGUKPiBzeXN0 ZW0gaXMgdW5kZXIgaGVhdnkgYXVkaXQgcHJlc3N1cmUsIGJ1dCBrYXVkaXRkX3RocmVhZCgpIHdp bGwKPiBjb250aW51ZSB0byBtYWtlIHByb2dyZXNzIGFuZCBkcmFpbiB0aGUgcXVldWVzIGFzIGl0 IHdvdWxkIGZvciBvdGhlcgo+IGNvbm5lY3Rpb24gcHJvYmxlbXMuICBGb3IgZXhhbXBsZSwgd2l0 aCB0aGUgYXVkaXQgZGFlbW9uIHB1dCBpbnRvIGEKPiBzdG9wcGVkIHN0YXRlIGFuZCB0aGUgc3lz dGVtIGNvbmZpZ3VyZWQgdG8gYXVkaXQgZXZlcnkgc3lzY2FsbCBpdAo+IHdhcyBzdGlsbCBwb3Nz aWJsZSB0byBzaHV0ZG93biB0aGUgc3lzdGVtIHdpdGhvdXQgYSBrZXJuZWwgcGFuaWMsCj4gZGVh ZGxvY2ssIGV0Yy47IGdyYW50ZWQsIHRoZSBzeXN0ZW0gd2FzIHNsb3cgdG8gc2h1dGRvd24gYnV0 IHRoYXQgaXMKPiB0byBiZSBleHBlY3RlZCBnaXZlbiB0aGUgZXh0cmVtZSBwcmVzc3VyZSBvZiBy ZWNvcmRpbmcgZXZlcnkgc3lzY2FsbC4KPgo+IFRoZSB0aW1lb3V0IHZhbHVlIG9mIEhaLzEwIHdh cyBjaG9zZW4gcHJpbWFyaWx5IHRocm91Z2gKPiBleHBlcmltZW50YXRpb24gYW5kIHRoaXMgZGV2 ZWxvcGVyJ3MgImd1dCBmZWVsaW5nIi4gIFRoZXJlIGlzIGxpa2VseQo+IG5vIG9uZSBwZXJmZWN0 IHZhbHVlLCBidXQgYXMgdGhpcyBzY2VuYXJpbyBpcyBsaW1pdGVkIGluIHNjb3BlIChyb290Cj4g cHJpdmlsZWdlcyB3b3VsZCBiZSBuZWVkZWQgdG8gc2VuZCBTSUdTVE9QIHRvIHRoZSBhdWRpdCBk YWVtb24pLCBpdAo+IGlzIGxpa2VseSBub3Qgd29ydGggZXhwb3NpbmcgdGhpcyBhcyBhIHR1bmFi bGUgYXQgcHJlc2VudC4gIFRoaXMgY2FuCj4gYWx3YXlzIGJlIGRvbmUgYXQgYSBsYXRlciBkYXRl IGlmIGl0IHByb3ZlcyBuZWNlc3NhcnkuCj4KPiBDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZwo+ IEZpeGVzOiA1YjUyMzMwYmJmZTYzICgiYXVkaXQ6IGZpeCBhdWRpdGQva2VybmVsIGNvbm5lY3Rp b24gc3RhdGUgdHJhY2tpbmciKQo+IFJlcG9ydGVkLWJ5OiBHYW9zaGVuZyBDdWkgPGN1aWdhb3No ZW5nMUBodWF3ZWkuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFBhdWwgTW9vcmUgPHBhdWxAcGF1bC1t b29yZS5jb20+Cj4gLS0tCj4gICBrZXJuZWwvYXVkaXQuYyB8ICAgMjEgKysrKysrKysrKy0tLS0t LS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMTEgZGVsZXRpb25z KC0pCj4KPiBkaWZmIC0tZ2l0IGEva2VybmVsL2F1ZGl0LmMgYi9rZXJuZWwvYXVkaXQuYwo+IGlu ZGV4IDEyMWQzN2U3MDBhNi4uNGNlYmFkYjVmMzBkIDEwMDY0NAo+IC0tLSBhL2tlcm5lbC9hdWRp dC5jCj4gKysrIGIva2VybmVsL2F1ZGl0LmMKPiBAQCAtNzE4LDcgKzcxOCw3IEBAIHN0YXRpYyBp bnQga2F1ZGl0ZF9zZW5kX3F1ZXVlKHN0cnVjdCBzb2NrICpzaywgdTMyIHBvcnRpZCwKPiAgIHsK PiAgIAlpbnQgcmMgPSAwOwo+ICAgCXN0cnVjdCBza19idWZmICpza2I7Cj4gLQlzdGF0aWMgdW5z aWduZWQgaW50IGZhaWxlZCA9IDA7Cj4gKwl1bnNpZ25lZCBpbnQgZmFpbGVkID0gMDsKPiAgIAo+ ICAgCS8qIE5PVEU6IGthdWRpdGRfdGhyZWFkIHRha2VzIGNhcmUgb2YgYWxsIG91ciBsb2NraW5n LCB3ZSBqdXN0IHVzZQo+ICAgCSAqICAgICAgIHRoZSBuZXRsaW5rIGluZm8gcGFzc2VkIHRvIHVz IChlLmcuIHNrIGFuZCBwb3J0aWQpICovCj4gQEAgLTczNSwzMiArNzM1LDMwIEBAIHN0YXRpYyBp bnQga2F1ZGl0ZF9zZW5kX3F1ZXVlKHN0cnVjdCBzb2NrICpzaywgdTMyIHBvcnRpZCwKPiAgIAkJ CWNvbnRpbnVlOwo+ICAgCQl9Cj4gICAKPiArcmV0cnk6Cj4gICAJCS8qIGdyYWIgYW4gZXh0cmEg c2tiIHJlZmVyZW5jZSBpbiBjYXNlIG9mIGVycm9yICovCj4gICAJCXNrYl9nZXQoc2tiKTsKPiAg IAkJcmMgPSBuZXRsaW5rX3VuaWNhc3Qoc2ssIHNrYiwgcG9ydGlkLCAwKTsKPiAgIAkJaWYgKHJj IDwgMCkgewo+IC0JCQkvKiBmYXRhbCBmYWlsdXJlIGZvciBvdXIgcXVldWUgZmx1c2ggYXR0ZW1w dD8gKi8KPiArCQkJLyogc2VuZCBmYWlsZWQgLSB0cnkgYSBmZXcgdGltZXMgdW5sZXNzIGZhdGFs IGVycm9yICovCj4gICAJCQlpZiAoKytmYWlsZWQgPj0gcmV0cnlfbGltaXQgfHwKPiAgIAkJCSAg ICByYyA9PSAtRUNPTk5SRUZVU0VEIHx8IHJjID09IC1FUEVSTSkgewo+IC0JCQkJLyogeWVzIC0g ZXJyb3IgcHJvY2Vzc2luZyBmb3IgdGhlIHF1ZXVlICovCj4gICAJCQkJc2sgPSBOVUxMOwo+ICAg CQkJCWlmIChlcnJfaG9vaykKPiAgIAkJCQkJKCplcnJfaG9vaykoc2tiKTsKPiAtCQkJCWlmICgh c2tiX2hvb2spCj4gLQkJCQkJZ290byBvdXQ7Cj4gLQkJCQkvKiBrZWVwIHByb2Nlc3Npbmcgd2l0 aCB0aGUgc2tiX2hvb2sgKi8KPiArCQkJCWlmIChyYyA9PSAtRUFHQUlOKQo+ICsJCQkJCXJjID0g MDsKPiArCQkJCS8qIGNvbnRpbnVlIHRvIGRyYWluIHRoZSBxdWV1ZSAqLwo+ICAgCQkJCWNvbnRp bnVlOwo+ICAgCQkJfSBlbHNlCj4gLQkJCQkvKiBubyAtIHJlcXVldWUgdG8gcHJlc2VydmUgb3Jk ZXJpbmcgKi8KPiAtCQkJCXNrYl9xdWV1ZV9oZWFkKHF1ZXVlLCBza2IpOwo+ICsJCQkJZ290byBy ZXRyeTsKPiAgIAkJfSBlbHNlIHsKPiAtCQkJLyogaXQgd29ya2VkIC0gZHJvcCB0aGUgZXh0cmEg cmVmZXJlbmNlIGFuZCBjb250aW51ZSAqLwo+ICsJCQkvKiBza2Igc2VudCAtIGRyb3AgdGhlIGV4 dHJhIHJlZmVyZW5jZSBhbmQgY29udGludWUgKi8KPiAgIAkJCWNvbnN1bWVfc2tiKHNrYik7Cj4g ICAJCQlmYWlsZWQgPSAwOwo+ICAgCQl9Cj4gICAJfQo+ICAgCj4gLW91dDoKPiAgIAlyZXR1cm4g KHJjID49IDAgPyAwIDogcmMpOwo+ICAgfQo+ICAgCj4gQEAgLTE2MDksNyArMTYwNyw4IEBAIHN0 YXRpYyBpbnQgX19uZXRfaW5pdCBhdWRpdF9uZXRfaW5pdChzdHJ1Y3QgbmV0ICpuZXQpCj4gICAJ CWF1ZGl0X3BhbmljKCJjYW5ub3QgaW5pdGlhbGl6ZSBuZXRsaW5rIHNvY2tldCBpbiBuYW1lc3Bh Y2UiKTsKPiAgIAkJcmV0dXJuIC1FTk9NRU07Cj4gICAJfQo+IC0JYXVuZXQtPnNrLT5za19zbmR0 aW1lbyA9IE1BWF9TQ0hFRFVMRV9USU1FT1VUOwo+ICsJLyogbGltaXQgdGhlIHRpbWVvdXQgaW4g Y2FzZSBhdWRpdGQgaXMgYmxvY2tlZC9zdG9wcGVkICovCj4gKwlhdW5ldC0+c2stPnNrX3NuZHRp bWVvID0gSFogLyAxMDsKPiAgIAo+ICAgCXJldHVybiAwOwo+ICAgfQo+Cj4gLgoKVGVzdGVkLWJ5 OiBHYW9zaGVuZyBDdWk8Y3VpZ2Fvc2hlbmcxQGh1YXdlaS5jb20+CgoKLS0KTGludXgtYXVkaXQg bWFpbGluZyBsaXN0CkxpbnV4LWF1ZGl0QHJlZGhhdC5jb20KaHR0cHM6Ly9saXN0bWFuLnJlZGhh dC5jb20vbWFpbG1hbi9saXN0aW5mby9saW51eC1hdWRpdA==