public inbox for linux-audit@redhat.com
 help / color / mirror / Atom feed
From: "Hassan Sultan" <hsultan@thefroid.net>
To: linux-audit@redhat.com, hsultan@thefroid.net
Subject: Re: ABI guarantee for auditd
Date: Thu, 15 Jan 2015 20:45:44 -0800	[thread overview]
Message-ID: <op.xsjguiax1jp0b1@content.bigsnout.com> (raw)
In-Reply-To: <67f972dd606a13a87560d389463a5390@thefroid.net>

On Thu, 15 Jan 2015 18:20:41 -0800, <hsultan@thefroid.net> wrote:

> On 2015-01-15 14:59, Steve Grubb wrote:
>> On Thursday, January 15, 2015 02:34:16 PM hsultan@thefroid.net wrote:
>>> On 2015-01-15 12:44, Steve Grubb wrote:
>>> > On Thursday, January 15, 2015 12:24:38 PM hsultan@thefroid.net wrote:
>>> >> Regarding auditd, what is the ABI guarantee ? Do you guarantee that
>>> >> the
>>> >> text contained in audit_reply->msg.data will always be the same
>>> >> format ?
>>> >> I imagine you reserve the right to add fields, but how about
>>> >> removing
>>> >> any or even reordering them ?
>>> >
>>> > Its happens on occasion. Requirements change, bugs are found, new
>>> > features asked for.
>>>
>>> Thanks, that tells me most of what I need, one last thing : do you
>>> happen to know if the 'big' distribs(Ubuntu,RH,CentOS,Debian...) ship
>>> those format changes only in new releases of their distribs, or do they
>>> include them in patches for existing releases as well ?
>>
>> I can't speak for other distributions, but if I find a mistake in the  
>> audit
>> records, I fix it to be right rather than hold ABI and stay forever  
>> wrong. This
>> doesn't happen very often. The audit records are mostly stable. But  
>> there are
>> 155 different records.
>
> Thanks for the info, so I tried using libauparse (again, Ubuntu 14.04  
> LTS), however I'm hitting something truly weird: once I've adddd the  
> event parsing code (taken from  
> https://fedorahosted.org/audit/browser/trunk/contrib/plugin/audisp-example.c  
> ) and added -lauparse, what I get out of audit_get_reply now is mangled.
> That clearly can't be a code mistake because I didn't touch the event  
> retrieval code, it's totally separate and runs in a separate thread,  
> dropping the messages retrieved in a queue that the parser picks from.  
> Weird thing is, even if I comment out the parsing code, the problem  
> remains. Then I even remove the libauparse lib from the link settings  
> and rebuild from scratch, problem remains. BUT then I reboot the box,  
> and the SAME PROCESS (no recompiling, just a reboot) now shows events  
> properly again.
>
> Is there a conflict or some specific setup between the 2 libraries I  
> should know about ? Does libauparse configures the audit infrastructure  
> in the kernel somehow ?
>
> My libauparse version is 1:2.3.2-2ubuntu1 and from dpkg-query it lists :
>
> Breaks: libaudit0, libaudit1 (<< 1:2.2.1-2)
>
> My libaudit is :
> Version: 1:2.3.2-2ubuntu1

Ok ignore my message, I'm truly an idiot and should pay more attention  
before I send questions here.

Sorry,

Hassan

  reply	other threads:[~2015-01-16  4:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 20:24 ABI guarantee for auditd hsultan
2015-01-15 20:44 ` Steve Grubb
2015-01-15 22:34   ` hsultan
2015-01-15 22:59     ` Steve Grubb
2015-01-16  2:20       ` hsultan
2015-01-16  4:45         ` Hassan Sultan [this message]
2015-01-16 13:48         ` Steve Grubb
2015-01-16 21:34           ` hsultan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=op.xsjguiax1jp0b1@content.bigsnout.com \
    --to=hsultan@thefroid.net \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox