From: shile.zhang@linux.alibaba.com
To: Coly Li <colyli@suse.de>, Kent Overstreet <kent.overstreet@gmail.com>
Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
Shile Zhang <shile.zhang@linux.alibaba.com>
Subject: [PATCH] bcache: add cond_resched() in __bch_cache_cmp()
Date: Thu, 7 Mar 2019 13:15:28 +0800 [thread overview]
Message-ID: <1551935728-243664-1-git-send-email-shile.zhang@linux.alibaba.com> (raw)
From: Shile Zhang <shile.zhang@linux.alibaba.com>
Read /sys/fs/bcache/<uuid>/cacheN/priority_stats can take very long
time with huge cache after long run.
Signed-off-by: Shile Zhang <shile.zhang@linux.alibaba.com>
---
drivers/md/bcache/sysfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c
index 557a8a3..028fea1 100644
--- a/drivers/md/bcache/sysfs.c
+++ b/drivers/md/bcache/sysfs.c
@@ -897,6 +897,7 @@ static void bch_cache_set_internal_release(struct kobject *k)
static int __bch_cache_cmp(const void *l, const void *r)
{
+ cond_resched();
return *((uint16_t *)r) - *((uint16_t *)l);
}
--
1.8.3.1
next reply other threads:[~2019-03-07 5:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-07 5:15 shile.zhang [this message]
2019-03-07 10:34 ` [PATCH] bcache: add cond_resched() in __bch_cache_cmp() Coly Li
2019-03-07 15:06 ` Shile Zhang
2019-03-07 15:36 ` Coly Li
2019-03-07 15:44 ` Vojtech Pavlik
2019-03-08 0:35 ` Shile Zhang
2019-03-08 2:19 ` Coly Li
2019-08-14 14:23 ` Heitor Alves de Siqueira
2019-08-14 16:50 ` Coly Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551935728-243664-1-git-send-email-shile.zhang@linux.alibaba.com \
--to=shile.zhang@linux.alibaba.com \
--cc=colyli@suse.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox