From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 05/13] block: Only clone bio vecs that are in use Date: Fri, 18 May 2012 09:13:34 -0700 Message-ID: <20120518161334.GE19388@google.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org To: koverstreet@google.com Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, axboe@kernel.dk, agk@redhat.com, neilb@suse.de List-Id: linux-bcache@vger.kernel.org On Thu, May 17, 2012 at 10:59:52PM -0400, koverstreet@google.com wrote: > diff --git a/fs/bio.c b/fs/bio.c > index e2c0970..de0733e 100644 > --- a/fs/bio.c > +++ b/fs/bio.c > @@ -435,8 +435,9 @@ EXPORT_SYMBOL(bio_phys_segments); > */ > void __bio_clone(struct bio *bio, struct bio *bio_src) > { > - memcpy(bio->bi_io_vec, bio_src->bi_io_vec, > - bio_src->bi_max_vecs * sizeof(struct bio_vec)); > + memcpy(bio->bi_io_vec, > + bio_iovec(bio_src), Unnecessary line break. > + bio_segments(bio_src) * sizeof(struct bio_vec)); > > /* > * most users will be overriding ->bi_bdev with a new target, > @@ -445,10 +446,10 @@ void __bio_clone(struct bio *bio, struct bio *bio_src) > bio->bi_sector = bio_src->bi_sector; > bio->bi_bdev = bio_src->bi_bdev; > bio->bi_flags |= 1 << BIO_CLONED; > + bio->bi_flags &= ~(1 << BIO_SEG_VALID); Can probably be conditionalized on bi_idx? Thanks. -- tejun