From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [dm-devel] [PATCH v8 3/8] dm: Use bioset's front_pad for dm_rq_clone_bio_info Date: Thu, 6 Sep 2012 15:28:49 -0700 Message-ID: <20120906222849.GI25236@google.com> References: <1346876849-15820-1-git-send-email-koverstreet@google.com> <1346876849-15820-4-git-send-email-koverstreet@google.com> <504816AB.8080105@ce.jp.nec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <504816AB.8080105-JhyGz2TFV9J8UrSeD/g0lQ@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jun'ichi Nomura Cc: device-mapper development , linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Alasdair Kergon , vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org List-Id: linux-bcache@vger.kernel.org On Thu, Sep 06, 2012 at 12:21:15PM +0900, Jun'ichi Nomura wrote: > On 09/06/12 05:27, Kent Overstreet wrote: > > @@ -2718,7 +2705,8 @@ struct dm_md_mempools *dm_alloc_md_mempools(unsigned type, unsigned integrity) > > if (!pools->tio_pool) > > goto free_io_pool_and_out; > > > > - pools->bs = bioset_create(pool_size, 0); > > + pools->bs = bioset_create(pool_size, > > + offsetof(struct dm_rq_clone_bio_info, clone)); > > if (!pools->bs) > > goto free_tio_pool_and_out; > > frontpad is not necessary if type is DM_TYPE_BIO_BASED. > > Other pool creation in that function do something like: > pools->bs = (type == DM_TYPE_BIO_BASED) ? > bioset_create(pool_size, 0) : > bioset_create(pool_size, offsetof(struct dm_rq_clone_bio_info, clone)); > Eh, it doesn't really matter considering it's two pointers of padding and struct bio + the inline vecs are something like 200 bytes, but I can do it if it makes you happy. Can I get someone's acked-by?