linux-bcache.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Muthu Kumar <muthu.lkml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kent Overstreet
	<koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
	linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
	Vivek Goyal <vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Mikulas Patocka
	<mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org,
	david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org
Subject: Re: [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers
Date: Tue, 11 Sep 2012 11:45:53 -0700	[thread overview]
Message-ID: <20120911184553.GT7677@google.com> (raw)
In-Reply-To: <CAFR8ued=Le4B4i_Rf4eECXsVgKvce9J7bO9sDSS91PFzBZ6j5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hello,

On Tue, Sep 11, 2012 at 11:36:28AM -0700, Muthu Kumar wrote:
> Does this preserve the CPU from which the bio was submitted
> originally. Not familiar with cmwq, may be Tejun can clarify.
> 
> Tejun - the question is, do we honor the rq_affinity with the above
> rescue worker implementation?

The work item would run from the same CPU but there isn't any
mechanism to keep track of the issuing CPU if there are multiple bios
to be rescued.  Isn't rq_affinity an optimization hint?  If so, I
don't think it matters here.

Thanks.

-- 
tejun

  parent reply	other threads:[~2012-09-11 18:45 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-07 22:12 [PATCH 0/2] Avoid deadlocks with bio allocation Kent Overstreet
     [not found] ` <1347055973-11581-1-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-07 22:12   ` [PATCH 1/2] block: Reorder struct bio_set Kent Overstreet
2012-09-07 22:12 ` [PATCH 2/2] block: Avoid deadlocks with bio allocation by stacking drivers Kent Overstreet
     [not found]   ` <1347055973-11581-3-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-08 19:36     ` Tejun Heo
     [not found]       ` <20120908193641.GB12773-RcKxWJ4Cfj1J2suj2OqeGauc2jM2gXBXkQQo+JxHRPFibQn6LdNjmg@public.gmane.org>
2012-09-10  0:28         ` Kent Overstreet
     [not found]           ` <20120910002810.GA23241-jC9Py7bek1znysI04z7BkA@public.gmane.org>
2012-09-10 15:25             ` Vivek Goyal
2012-09-10 17:22             ` Tejun Heo
     [not found]               ` <20120910172210.GC14103-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 20:24                 ` Kent Overstreet
     [not found]                   ` <20120910202435.GG16360-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 20:40                     ` Tejun Heo
     [not found]                       ` <20120910204010.GA32310-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 21:33                         ` Kent Overstreet
     [not found]                           ` <20120910213349.GH16360-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 21:37                             ` Tejun Heo
2012-09-10 21:56                               ` Kent Overstreet
     [not found]                                 ` <20120910215633.GA19739-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 22:09                                   ` Tejun Heo
     [not found]                                     ` <20120910220910.GB7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 22:50                                       ` [dm-devel] " Alasdair G Kergon
     [not found]                                         ` <20120910225057.GA10477-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2012-09-10 23:01                                           ` Tejun Heo
2012-09-10 23:06                                             ` Kent Overstreet
     [not found]                                             ` <CAOS58YO5puV2iPhwe0vbyEydPnR=eWPStNRm=xEpMeo-TMHCaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-10 23:09                                               ` Alasdair G Kergon
     [not found]                                                 ` <20120910230917.GB10477-FDJ95KluN3Z0klwcnFlA1dvLeJWuRmrY@public.gmane.org>
2012-09-10 23:35                                                   ` Tejun Heo
     [not found]                                                     ` <20120910233502.GH7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-10 23:45                                                       ` Alasdair G Kergon
2012-09-10 23:01                                           ` Kent Overstreet
2012-09-10 23:13                                       ` Tejun Heo
2012-09-11 18:36                                   ` Muthu Kumar
     [not found]                                     ` <CAFR8ued=Le4B4i_Rf4eECXsVgKvce9J7bO9sDSS91PFzBZ6j5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-09-11 18:45                                       ` Tejun Heo [this message]
     [not found]                                         ` <20120911184553.GT7677-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 18:58                                           ` Muthu Kumar
2012-09-11 19:31                                             ` Kent Overstreet
     [not found]                                               ` <20120911193124.GI19739-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-09-11 20:00                                                 ` Muthu Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120911184553.GT7677@google.com \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
    --cc=bharrosh-C4P08NqkoRlBDgjK7y7TUQ@public.gmane.org \
    --cc=david-FqsqvQoI3Ljby3iVrkZq2A@public.gmane.org \
    --cc=dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=muthu.lkml-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).