From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: [dm-devel] [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix Date: Tue, 11 Sep 2012 15:07:50 -0700 Message-ID: <20120911220750.GM19739@google.com> References: <1347322957-25260-1-git-send-email-koverstreet@google.com> <1347322957-25260-2-git-send-email-koverstreet@google.com> <20120911203643.GC17113@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20120911203643.GC17113@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Vivek Goyal Cc: linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, axboe@kernel.dk, tj@kernel.org, "Martin K. Petersen" List-Id: linux-bcache@vger.kernel.org On Tue, Sep 11, 2012 at 04:36:43PM -0400, Vivek Goyal wrote: > Also there seems to be too much happening in this patch. Please break > it down in 2. First fix the bio integrity bug you mentioned then > introduce your changes on top. Oh, I forgot - the reason I squashed them into one patch is fixing the bug came for free with the rest of the refactoring, and combining them touches less code. To fix the bug first, I'd have to reorder struct bio_pair and then just delete two lines of code from bio_integrity_split(). But the reordering is unnecessary with the refactoring.