From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alasdair G Kergon Subject: Re: [dm-devel] [PATCH v10 1/8] block: Generalized bio pool freeing Date: Fri, 14 Sep 2012 19:36:10 +0100 Message-ID: <20120914183610.GL15728@agk-dp.fab.redhat.com> References: <1346970902-10931-1-git-send-email-koverstreet@google.com> <1346970902-10931-2-git-send-email-koverstreet@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1346970902-10931-2-git-send-email-koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Jens Axboe , Lars Ellenberg , Alasdair Kergon , Hannes Reinecke List-Id: linux-bcache@vger.kernel.org On Thu, Sep 06, 2012 at 03:34:55PM -0700, Kent Overstreet wrote: > With the old code, when you allocate a bio from a bio pool you have to > implement your own destructor that knows how to find the bio pool the > bio was originally allocated from. > This adds a new field to struct bio (bi_pool) and changes > bio_alloc_bioset() to use it. This makes various bio destructors > unnecessary, so they're then deleted. If you reinstate commit 4d7b38b7d944a79da3793b6c92d38682f3905ac9 "dm: clear bi_end_io on remapping failure", Acked-by: Alasdair Kergon for the device-mapper parts. Alasdair