From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v2 01/26] block: Convert integrity to bvec_alloc_bs(), and a bugfix Date: Fri, 19 Oct 2012 13:36:06 -0700 Message-ID: <20121019203606.GU13370@google.com> References: <1350331769-14856-1-git-send-email-koverstreet@google.com> <1350331769-14856-31-git-send-email-koverstreet@google.com> <20121019203421.GT13370@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20121019203421.GT13370-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kent Overstreet Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, neilb-l3A5Bk7waGM@public.gmane.org, "Martin K. Petersen" List-Id: linux-bcache@vger.kernel.org On Fri, Oct 19, 2012 at 01:34:21PM -0700, Tejun Heo wrote: > On Mon, Oct 15, 2012 at 01:09:04PM -0700, Kent Overstreet wrote: > > This adds a pointer to the bvec array to struct bio_integrity_payload, > > instead of the bvecs always being inline; then the bvecs are allocated > > with bvec_alloc_bs(). > > > > This is needed eventually for immutable bio vecs - immutable bvecs > > aren't useful if we still have to copy them, hence the need for the > > pointer. Less code is always nice too, though. > > > > Also fix an amusing bug in bio_integrity_split() - struct bio_pair > > doesn't have the integrity bvecs after the bio_integrity_payloads, so > > there was a buffer overrun. The code was confusing pointers with arrays. > > Ummm... patch description doesn't agree with the patch content? And the patch posted doesn't match the commit in git branch. Dazed and confused. Bailing out. Let's retry next time. -- tejun