public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <koverstreet-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
To: James Sefton <james-3k2nYdb70uTQXOPxS62xeg@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: Partitions?
Date: Fri, 2 Nov 2012 08:33:35 -0700	[thread overview]
Message-ID: <20121102153335.GD14917@google.com> (raw)
In-Reply-To: <loom.20121102T041855-678-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>

On Fri, Nov 02, 2012 at 03:24:13AM +0000, James Sefton wrote:
> Hi,
> 
> I have got my /dev/bcache0 device showing up and attached the cache.
> 
> I then used fdisk to add a single partition to it but it gave an error on exit:
> 
> WARNING: Re-reading the partition table failed with error 22: Invalid argument.
> The kernel still uses the old table. The new table will be used at
> the next reboot or after you run partprobe(8) or kpartx(8)
> 
> 
> I have had this before quite a bit and often have to run partprobe after leaving 
> fdisk for the partition table to be read and partitions populated in /dev.
> 
> However, when running partprobe (or partprobe /dev/bcache0) I get the following:
> 
> Error: Error informing the kernel about modifications to partition 
> /dev/bcache0p1 -- Invalid argument.  This means Linux won't know about any 
> changes you made to /dev/bcache0p1 until you reboot -- so you shouldn't mount it 
> or use it in any way before rebooting.
> Error: Failed to add partition 1 (Invalid argument)
> 
> 
> I checked /dev and confirmed that bcache0p1 was not present.
> 
> 
> What did I do wrong?

Oh, that's nothing you did... the bcache code is just creating an
unpartitionalable block device.

I suppose there's no real reason for that...

I _think_ all you'd need to change is one line, in
drivers/md/bcache/super.c: if you search through the file, you'll find a
call to alloc_disk(1) somewhere - change that to alloc_disk(16).


Want to try that and let me know if it works?

  parent reply	other threads:[~2012-11-02 15:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  3:24 Partitions? James Sefton
     [not found] ` <loom.20121102T041855-678-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2012-11-02 15:33   ` Kent Overstreet [this message]
     [not found]     ` <20121102153335.GD14917-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2012-11-02 19:11       ` Partitions? James Sefton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121102153335.GD14917@google.com \
    --to=koverstreet-hpiqsd4aklfqt0dzr+alfa@public.gmane.org \
    --cc=james-3k2nYdb70uTQXOPxS62xeg@public.gmane.org \
    --cc=linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox