Raw stats

Raw stats

[Stefan Priebe - Profihost AG]

The stats_total counters are formatted to GB MB,... for several use cases raw values would be better (f.e.nagios plugin). Is this possible?

Stefan--
To unsubscribe from this list: send the line "unsubscribe linux-bcache" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Raw stats

[Kent Overstreet]

On Thu, Jul 11, 2013 at 07:35:01AM +0200, Stefan Priebe - Profihost AG wrote:
> The stats_total counters are formatted to GB MB,... for several use cases raw values would be better (f.e.nagios plugin). Is this possible?

Heh, I imagine Greg K-H or someone would say the sysfs stuff should only
be exporting the raw values..

It'd be pretty easy to add _raw versions, though - or maybe _bytes? I'm
not terribly eager to wade through the sysfs code right this minute, but
the sysfs code should be pretty easy to figure out if you want to try
it and I'd take a patch.

(Look for sysfs_hprint() calls in sysfs.c and stats.c; add attributes
(the read_attribute() things) for the files you want to add and
sysfs_print() calls for the raw versions)

Re: Raw stats

[Stefan Priebe - Profihost AG]

Am 12.07.2013 03:33, schrieb Kent Overstreet:
> On Thu, Jul 11, 2013 at 07:35:01AM +0200, Stefan Priebe - Profihost AG wrote:
>> The stats_total counters are formatted to GB MB,... for several use cases raw values would be better (f.e.nagios plugin). Is this possible?
> 
> Heh, I imagine Greg K-H or someone would say the sysfs stuff should only
> be exporting the raw values..
> 
> It'd be pretty easy to add _raw versions, though - or maybe _bytes? I'm
> not terribly eager to wade through the sysfs code right this minute, but
> the sysfs code should be pretty easy to figure out if you want to try
> it and I'd take a patch.
> 
> (Look for sysfs_hprint() calls in sysfs.c and stats.c; add attributes
> (the read_attribute() things) for the files you want to add and
> sysfs_print() calls for the raw versions)

I would vote for dropping this human stuff too and use raw / byte values
in general. Makeing nice looking values out of it is always up to utils
or the user.

Greets,
Stefan