From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kent Overstreet Subject: Re: reverse link from bucket to keys Date: Thu, 11 Jul 2013 19:25:51 -0700 Message-ID: <20130712022551.GB30223@kmo-pixel> References: <20130708214859.GB1959@kmo-pixel> <20130710230257.GD13527@kmo-pixel> <20130712021057.GA30223@kmo-pixel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: sheng qiu Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-bcache@vger.kernel.org On Thu, Jul 11, 2013 at 10:22:02PM -0400, sheng qiu wrote: > Hi Kent, > > thanks for the explain above. my concern is that the GC_SECTORS_USED > does not get you the correct valid data size within each bucket. for > example, the GC_SECTORS_USED might return you larger than the bucket > size, while when you go to match the reserved_sectors, you might get > wrong. i do not know if you get my meaning. A simple way is run some > test while enable the GC code, you will see how it work actually. If > it's my misunderstanding, i am glad to hear from you later. I'm not sure I follow - if GC_SECTORS_USED was > bucket size that'd probably be a bug, but I don't see how that could happen - could you explain?