From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kent Overstreet <kmo-PEzghdH756F8UrSeD/g0lQ@public.gmane.org>
Subject: Re: reverse link from bucket to keys
Date: Thu, 11 Jul 2013 19:41:25 -0700
Message-ID: <20130712024125.GC30223@kmo-pixel>
References: <CAB7xdi=wn1O4+g8cynMpSrD114RVsXf4O6Jzz+cytcb=RZhHAg@mail.gmail.com>
 <CAB7xdinPKr6orbY4Oc-CH-e5aeGwghLsiTFmFC4Qs80PwniBcg@mail.gmail.com>
 <20130710230257.GD13527@kmo-pixel>
 <CAB7xdik_nDtJbz-YBaKkQ6XDVQT65ZiSB9E7WWZHon8jXH57SQ@mail.gmail.com>
 <CAB7xdikjXhAyM5dqVXuEUgL4RHM4L0uf0ksXZ_6uU3-ZgAKR4g@mail.gmail.com>
 <CAB7xdinRH6ysM6O1x4jB00acqOvtRwPN00xjm2jkmvML37f3JQ@mail.gmail.com>
 <20130712021057.GA30223@kmo-pixel>
 <CAB7xdimtWj728xp9amk=K3-dnCWugFYLSUDuueHQwRYOP13dmw@mail.gmail.com>
 <20130712022551.GB30223@kmo-pixel>
 <CAB7xdinz82AstkNTptXa2z3VFsAB4AT3NXf-Y0X7PZ+27k6iAw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Content-Disposition: inline
In-Reply-To: <CAB7xdinz82AstkNTptXa2z3VFsAB4AT3NXf-Y0X7PZ+27k6iAw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Sender: linux-bcache-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
To: sheng qiu <herbert1984106-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-bcache-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
List-Id: linux-bcache@vger.kernel.org

On Thu, Jul 11, 2013 at 10:29:23PM -0400, sheng qiu wrote:
> sure, in your btree.c code, when you do btree gc, you update the
> bucket's used sectors by min(unsigned, GC_SECTORS_USED(b)+key_size(),
> 1<<14-1). this might get you larger than the bucket size. since the
> newly allocated bucket is set to bucket size already. so each round
> you will accumulate the key_size(). i print the information at that
> point, and see GC_SECTORS_USED > bucket size.

Hey, I think you're right - btree_gc_start() is supposed to be zeroing
out GC_SECTORS_USED() (the same place it does SET_GC_MARK(b,
GC_MARK_RECLAIMABLE)) - but that's missing. Thanks!