From: majianpeng <majianpeng@gmail.com>
To: kmo <kmo@daterainc.com>
Cc: linux-bcache <linux-bcache@vger.kernel.org>
Subject: [PATCH 2/3] bcache: Avoid hung task happen.
Date: Wed, 8 Jan 2014 19:39:26 +0800 [thread overview]
Message-ID: <201401081939218365334@gmail.com> (raw)
Because after kthread_create, the state of kthread is TASK_UNINTERRUPTIBLE.
If we don't wake up dc->writeback_thread, the thread will be hung-task.
For those reasons, we don't wake up writeback_thread:
A:only create backed device
B:create backed device and cache device, but don't write at once
C:write without writeback poliy
So like the way of create gc_thread, after creating writeback_thread, i
set the state is TASK_INTERRUPTIBLE.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/bcache/writeback.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 6c44fe0..7fbc22a 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -499,6 +499,8 @@ int bch_cached_dev_writeback_init(struct cached_dev *dc)
if (IS_ERR(dc->writeback_thread))
return PTR_ERR(dc->writeback_thread);
+ set_task_state(dc->writeback_thread, TASK_INTERRUPTIBLE);
+
INIT_DELAYED_WORK(&dc->writeback_rate_update, update_writeback_rate);
schedule_delayed_work(&dc->writeback_rate_update,
dc->writeback_rate_update_seconds * HZ);
--
1.7.10.4
next reply other threads:[~2014-01-08 11:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 11:39 majianpeng [this message]
2014-01-08 21:34 ` [PATCH 2/3] bcache: Avoid hung task happen Kent Overstreet
2014-01-09 3:00 ` majianpeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401081939218365334@gmail.com \
--to=majianpeng@gmail.com \
--cc=kmo@daterainc.com \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).