From: Vojtech Pavlik <vojtech@suse.com>
To: Eric Wheeler <bcache@lists.ewheeler.net>
Cc: linux-bcache@vger.kernel.org
Subject: Re: bcache: remove driver private bio splitting code
Date: Wed, 13 Jan 2016 06:54:00 +0100 [thread overview]
Message-ID: <20160113055400.GA32697@suse.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1601121759100.10151@mail.ewheeler.net>
On Tue, Jan 12, 2016 at 06:00:49PM -0800, Eric Wheeler wrote:
Hello Eric,
> Have you tested the patch below in SLE12-* when bcache is backed by md
> raid5/6?
>
> FYI: I was compared the drivers/md/bcache/io.c functions in the various
> branches here:
> https://github.com/openSUSE/kernel
> I compared the presence of bch_generic_make_request() (which the patch
> below removes). It looks like the branch SLE12-SP2 has the patch, but
> version before SLE12-SP2 and openSUSE-* do not (as they still have
> bch_generic_make_request).
>
> Since the patch does exist in SLE12-SP2, I'm guessing that is been tested,
> though I am curious if it has been tested specifically when being backed
> by md raid5/6 so that queue->limits->partial_stripes_expensive is nonzero.
>
> If you have and it is stable, then I want to get it to Kent and Jens for
> upstream integration.
The SLES12-SP2 kernel branch is very fresh, created this week. So while
the patch was tested by Johannes before adding it, and by our per-commit
automated tests, it didn't go through fully qualified QA test cycle yet.
So I won't say it's proven stable just yet.
--
Vojtech Pavlik
Director SUSE Labs
next prev parent reply other threads:[~2016-01-13 5:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1439363241-31772-1-git-send-email-mlin@kernel.org>
2015-08-12 7:07 ` [PATCH v6 03/11] bcache: remove driver private bio splitting code Ming Lin
2016-01-08 1:53 ` Eric Wheeler
2016-01-13 2:00 ` Eric Wheeler
2016-01-13 5:54 ` Vojtech Pavlik [this message]
2016-01-13 23:03 ` Eric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113055400.GA32697@suse.com \
--to=vojtech@suse.com \
--cc=bcache@lists.ewheeler.net \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox