public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: Kent Overstreet <kent.overstreet@gmail.com>
To: Marcin <marcin@mejor.pl>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [bcachefs] time of mounting filesystem with high number of dirs
Date: Wed, 7 Sep 2016 13:12:12 -0800	[thread overview]
Message-ID: <20160907211212.6pvxo7p5z3v2nvhf@kmo-pixel> (raw)
In-Reply-To: <5c0639691edb57d1b63b06effb5283d1@mejor.pl>

On Wed, Sep 07, 2016 at 10:09:58PM +0200, Marcin wrote:
> Hi!
> I'm aware that performance doesn't have high priority, it's something for
> TODO.
> I created bcachefs on ~10GB partition, copied some files and next I created
> huge number of directories and files. Problem is in the total time needed
> for mounting filesystem.
> # time mount -t bcache /dev/sde1 /mnt/test/
> 
> real    12m20.880s
> user    0m0.000s
> sys     1m18.270s

Oh damn, guess it's time to start working on mount time... I knew this was going
to be an issue sooner or later, but 12 minutes is impressive :)

> I looked at iostat, mounting needs to read from disk 10083588 "kB_read".
> Device has size 10485760kB, so it looks that it reads almost the same amount
> of data as partition size. Maybe mount time can be lower? Maybe there can be
> less reads or reads could be more sequential?

So, right now we're checking i_nlinks on every mount - mainly the dirents
implementation predates the transactional machinery we have now. That's almost
definitely what's taking so long, but I'll send you a patch to confirm later.

It shouldn't take that much work to make the relevant filesystem code
transactional, I'll bump that up on the todo list...

  reply	other threads:[~2016-09-07 21:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-07 20:09 [bcachefs] time of mounting filesystem with high number of dirs Marcin
2016-09-07 21:12 ` Kent Overstreet [this message]
2016-09-09  1:56   ` Kent Overstreet
2016-09-09  2:07     ` Christopher James Halse Rogers
2016-09-09  7:52     ` Marcin Mirosław
2016-09-09  9:00       ` Kent Overstreet
2016-09-12 12:59         ` Marcin
2016-09-13  2:35           ` Kent Overstreet
2016-10-05 12:51             ` Marcin Mirosław
2016-10-06 13:01               ` Kent Overstreet
2016-10-18 12:14         ` [bcachefs] time of mounting filesystem with high number of dirs aka ageing filesystem Marcin Mirosław
2016-10-18 12:45           ` Kent Overstreet
2016-10-18 12:51             ` Marcin Mirosław
2016-10-18 13:04               ` Kent Overstreet
2016-10-18 13:13                 ` Marcin Mirosław
2016-10-18 13:19               ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160907211212.6pvxo7p5z3v2nvhf@kmo-pixel \
    --to=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=marcin@mejor.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox