From: Kent Overstreet <kent.overstreet@gmail.com>
To: "Marcin Mirosław" <marcin@mejor.pl>
Cc: linux-bcache@vger.kernel.org
Subject: Re: [bcachefs][tier] INFO: task bch_tier_read:21414 blocked for more than 120 seconds.
Date: Mon, 17 Oct 2016 22:30:15 -0800 [thread overview]
Message-ID: <20161018063015.q2fh32rmr33epcvu@kmo-pixel> (raw)
In-Reply-To: <f9b01a85-2b08-179b-9b60-3efc85795ae8@mejor.pl>
On Tue, Oct 18, 2016 at 08:07:14AM +0200, Marcin Mirosław wrote:
> W dniu 2016-10-18 o 02:30, Kent Overstreet pisze:
> > On Wed, Oct 12, 2016 at 09:51:17PM +0200, Marcin wrote:
> > > W dniu 2016-10-12 21:19, Kent Overstreet napisał(a):
> > > > It needs to return true, not false.
> > >
> > > It's not a bash, ok:)
> > >
> > > With:
> > > --- a/drivers/md/bcache/journal.h
> > > +++ b/drivers/md/bcache/journal.h
> > > @@ -184,7 +184,8 @@ static inline unsigned jset_u64s(unsigned u64s)
> > >
> > > static inline bool journal_flushes_device(struct cache *ca)
> > > {
> > > - return ca->mi.tier == 0;
> > > + /** return ca->mi.tier == 0; **/
> > > + return true;
> >
> > Chris retested with the latest bcache-dev and it seems to be working for him
> > now - can you retest with bcache-dev too?
>
>
> Hi!
> I retested, I can't trigger this bug again. It looks you fixed this. Thanks!
Great!
> I noticed that umounting filesystem gives me such messages:
> [ 4460.050248] bch_write: 7 callbacks suppressed
> [ 4460.050261] bcache (53f02c70-608f-48e9-bdb9-53132b44fce4): IO error: read
> only
> [ 4460.240296] bcache (53f02c70-608f-48e9-bdb9-53132b44fce4): stopped
>
> Is it something important?
Oh, it looks like things are getting shutdown in slightly the wrong order now.
It's completely harmless, though.
prev parent reply other threads:[~2016-10-18 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 21:13 [bcachefs][tier] INFO: task bch_tier_read:21414 blocked for more than 120 seconds Marcin
2016-10-12 1:26 ` Kent Overstreet
2016-10-12 11:07 ` Marcin Mirosław
2016-10-12 12:11 ` Kent Overstreet
2016-10-12 19:10 ` Marcin
[not found] ` <CAC7rs0vU1KTsf1KmbCJg3GWLrsKd4aA=j=vCezyBPTuVFxOHQg@mail.gmail.com>
2016-10-12 19:51 ` Marcin
2016-10-15 6:17 ` Kent Overstreet
2016-10-18 0:30 ` Kent Overstreet
2016-10-18 6:07 ` Marcin Mirosław
2016-10-18 6:30 ` Kent Overstreet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018063015.q2fh32rmr33epcvu@kmo-pixel \
--to=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=marcin@mejor.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox