public inbox for linux-bcache@vger.kernel.org
 help / color / mirror / Atom feed
From: Vojtech Pavlik <vojtech@suse.com>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: James Pharaoh <james@pharaoh.uk>, linux-bcache@vger.kernel.org
Subject: Re: Extra write mode to close RAID5 write hole (kind of)
Date: Fri, 28 Oct 2016 18:55:06 +0200	[thread overview]
Message-ID: <20161028165506.GA7233@suse.com> (raw)
In-Reply-To: <20161028131310.4fi4vm54fgsl7nqg@kmo-pixel>

On Fri, Oct 28, 2016 at 05:13:10AM -0800, Kent Overstreet wrote:
> t
> On Fri, Oct 28, 2016 at 03:07:20PM +0200, Vojtech Pavlik wrote:
> > The only situation where data damage can happen is a power outage that
> > comes together with a loss of one of the drives. In such a case, the
> > content of any blocks written past the last barrier is undefined. It
> > then depends on the filesystem whether it can revert to the last sane
> > state. Not sure about others, but btrfs will do so.
> 
> It's not any data written since the last barrier - in a non COW filesystem,
> potentially the entire stripe is toast, which means existing unrelated data gets
> corrupted. There's nothing really a non COW filesystem can do about it.

Again, you're right, if a drive is lost during a power outage, there can
be damage even outside of the blocks that were written if plain data was
written and xor wasn't. I don't think there is a filesystem that can
handle damage to untouched data cleanly.

An additional journal that works closely with the RAID device and tracks
what has been written to all devices is required to close this remaining gap.

But then, if the journal device is lost during a power outage ... ;)

-- 
Vojtech Pavlik
Director SuSE Labs

  reply	other threads:[~2016-10-28 16:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 15:20 Extra write mode to close RAID5 write hole (kind of) James Pharaoh
2016-10-26 22:31 ` Vojtech Pavlik
2016-10-27 21:46   ` James Pharaoh
2016-10-28 11:52   ` Kent Overstreet
2016-10-28 13:07     ` Vojtech Pavlik
2016-10-28 13:13       ` Kent Overstreet
2016-10-28 16:55         ` Vojtech Pavlik [this message]
2016-10-28 16:58       ` James Pharaoh
2016-10-28 17:07     ` James Pharaoh
2016-10-29  0:58       ` Kent Overstreet
2016-10-29 19:58         ` James Pharaoh
2016-10-28 11:59 ` Kent Overstreet
2016-10-28 17:02   ` James Pharaoh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161028165506.GA7233@suse.com \
    --to=vojtech@suse.com \
    --cc=james@pharaoh.uk \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-bcache@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox