From: Kai Krakow <kai@kaishome.de>
To: Coly Li <i@coly.li>
Cc: linux-bcache@vger.kernel.org, Eric Wheeler <bcache@lists.ewheeler.net>
Subject: Re: [4.9.1] Compiler warnings in bcache
Date: Tue, 10 Jan 2017 21:51:34 +0100 [thread overview]
Message-ID: <20170110215134.4d2ea291@jupiter.sol.local> (raw)
In-Reply-To: <8ca97b22-9888-fa22-5086-46f36eaaa931@coly.li>
Am Tue, 10 Jan 2017 13:41:25 +0800
schrieb Coly Li <i@coly.li>:
> On 2017/1/10 上午2:34, Kai Krakow wrote:
> > When compiling kernel 4.9.1, I'm seeing the following warnings:
> >
> > In file included from ./include/linux/bio.h:23:0,
> > from drivers/md/bcache/bcache.h:181,
> > from drivers/md/bcache/writeback.c:9:
> > drivers/md/bcache/writeback.c: In Funktion
> > »bch_cached_dev_writeback_init«: ./include/linux/ioprio.h:15:73:
> > Warnung: Klammern um Arithmetik in Operand von »|« empfohlen
> > [-Wparentheses] #define IOPRIO_PRIO_VALUE(class, data) (((class) <<
> > IOPRIO_CLASS_SHIFT) | data) ^ drivers/md/bcache/writeback.c:515:25:
> > Anmerkung: bei Substitution des Makros »IOPRIO_PRIO_VALUE«
> > dc->ioprio_bypass = IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE,
> > IOPRIO_BE_NR-1); ^
> >
> > It suggests to put parentheses around the expression with the "|"
> > operand. No other kernel source files show warnings for me, so
> > maybe it should be fixed.
> >
> > I would create a patch myself but I'm not sure if it would be
> > correct and sufficient to put parenthesis around "data" like this:
> >
> > #define IOPRIO_PRIO_VALUE(class, data) (((class) <<
> > IOPRIO_CLASS_SHIFT) | (data))
>
> Hi Kai Krakow,
>
> This fix is necessary, please send a patch to IOPRIO_PRIO_VALUE().
>
> BTW, I don't see dc->ioprio_bypass from upstream kernel source, is it
> from a development tree ?
Ahhh... This is from Erics ioprio bypass patches. I'm still using the
4.8 patchset with 4.9. Maybe it has been updated meanwhile?
--
Regards,
Kai
Replies to list-only preferred.
next prev parent reply other threads:[~2017-01-10 20:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 18:34 [4.9.1] Compiler warnings in bcache Kai Krakow
2017-01-10 5:41 ` Coly Li
2017-01-10 20:51 ` Kai Krakow [this message]
2017-01-15 9:36 ` Coly Li
2017-01-31 19:01 ` IOPRIO_PRIO_VALUE needs parens around (data) (was: [4.9.1] Compiler warnings in bcache) Eric Wheeler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170110215134.4d2ea291@jupiter.sol.local \
--to=kai@kaishome.de \
--cc=bcache@lists.ewheeler.net \
--cc=i@coly.li \
--cc=linux-bcache@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox