From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH] bcache: avoid a dangerous addressing in closure_queue Date: Wed, 5 Jul 2017 20:36:28 -0700 Message-ID: <20170706033628.GA1007@infradead.org> References: <1499259199-15161-1-git-send-email-liangchen.linux@gmail.com> <20170705193143.GA1050@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([65.50.211.133]:53130 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbdGFDg3 (ORCPT ); Wed, 5 Jul 2017 23:36:29 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: Liang Chen Cc: Christoph Hellwig , linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org, colyli@suse.de, bcache@linux.ewheeler.net On Thu, Jul 06, 2017 at 08:18:02AM +0800, Liang Chen wrote: > But as you pointed out, explicit casting is still bad too (was hoping it can be > considered less bad at this situation). I will think of a better idea > to handle this > issue unless people agree that the current behaviour is safe. Yes, let's find a way to avoids both the implicit and the explicit cast.