Re: [PATCH v4] bcache: Don't reinvent the wheel but use existing llist API

Coly Li
2017-08-18T06:04:33Z

On 2017/8/18 上午9:24, Byungchul Park wrote:
> On Fri, Aug 11, 2017 at 01:42:23PM +0900, Byungchul Park wrote:
>> Although llist provides proper APIs, they are not used. Make them used.
>
> Any opinions about this?
>

The patch is good. If Eric has no time, I will take care of it later.

Thanks.

Coly

>>
>> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
>> Acked-by: Coly Li <colyli@suse.de>
>> ---
>> drivers/md/bcache/closure.c | 15 ++-------------
>> 1 file changed, 2 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/md/bcache/closure.c b/drivers/md/bcache/closure.c
>> index 864e673..7d5286b 100644
>> --- a/drivers/md/bcache/closure.c
>> +++ b/drivers/md/bcache/closure.c
>> @@ -70,21 +70,10 @@ void __closure_wake_up(struct closure_waitlist *wait_list)
>> list = llist_del_all(&wait_list->list);
>>
>> /* We first reverse the list to preserve FIFO ordering and fairness */
>> -
>> - while (list) {
>> - struct llist_node *t = list;
>> - list = llist_next(list);
>> -
>> - t->next = reverse;
>> - reverse = t;
>> - }
>> + reverse = llist_reverse_order(list);
>>
>> /* Then do the wakeups */
>> -
>> - while (reverse) {
>> - cl = container_of(reverse, struct closure, list);
>> - reverse = llist_next(reverse);
>> -
>> + llist_for_each_entry(cl, reverse, list) {
>> closure_set_waiting(cl, 0);
>> closure_sub(cl, CLOSURE_WAITING + 1);
>> }
>> --
>> 1.9.1