From mboxrd@z Thu Jan 1 00:00:00 1970 From: Coly Li Subject: [PATCH 10/12] bcache: silence static checker warning Date: Wed, 6 Sep 2017 14:26:00 +0800 Message-ID: <20170906062602.50497-11-colyli@suse.de> References: <20170906062602.50497-1-colyli@suse.de> Return-path: In-Reply-To: <20170906062602.50497-1-colyli@suse.de> Sender: linux-block-owner@vger.kernel.org To: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, axboe@kernel.dk Cc: bcache@lists.ewheeler.net, Dan Carpenter List-Id: linux-bcache@vger.kernel.org From: Dan Carpenter In olden times, closure_return() used to have a hidden return built in. We removed the hidden return but forgot to add a new return here. If "c" were NULL we would oops on the next line, but fortunately "c" is never NULL. Let's just remove the if statement. Signed-off-by: Dan Carpenter Reviewed-by: Coly Li --- drivers/md/bcache/super.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 253918972335..c5deec621fdd 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1376,9 +1376,6 @@ static void cache_set_flush(struct closure *cl) struct btree *b; unsigned i; - if (!c) - closure_return(cl); - bch_cache_accounting_destroy(&c->accounting); kobject_put(&c->internal); -- 2.13.5