From: Coly Li <colyli@suse.de>
To: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
axboe@kernel.dk
Cc: bcache@lists.ewheeler.net, Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH 11/12] bcache: Update continue_at() documentation
Date: Wed, 6 Sep 2017 14:26:01 +0800 [thread overview]
Message-ID: <20170906062602.50497-12-colyli@suse.de> (raw)
In-Reply-To: <20170906062602.50497-1-colyli@suse.de>
From: Dan Carpenter <dan.carpenter@oracle.com>
continue_at() doesn't have a return statement anymore.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Coly Li <colyli@suse.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/bcache/closure.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/md/bcache/closure.h b/drivers/md/bcache/closure.h
index 1ec84ca81146..295b7e43f92c 100644
--- a/drivers/md/bcache/closure.h
+++ b/drivers/md/bcache/closure.h
@@ -312,8 +312,6 @@ static inline void closure_wake_up(struct closure_waitlist *list)
* been dropped with closure_put()), it will resume execution at @fn running out
* of @wq (or, if @wq is NULL, @fn will be called by closure_put() directly).
*
- * NOTE: This macro expands to a return in the calling function!
- *
* This is because after calling continue_at() you no longer have a ref on @cl,
* and whatever @cl owns may be freed out from under you - a running closure fn
* has a ref on its own closure which continue_at() drops.
@@ -340,8 +338,6 @@ do { \
* Causes @fn to be executed out of @cl, in @wq context (or called directly if
* @wq is NULL).
*
- * NOTE: like continue_at(), this macro expands to a return in the caller!
- *
* The ref the caller of continue_at_nobarrier() had on @cl is now owned by @fn,
* thus it's not safe to touch anything protected by @cl after a
* continue_at_nobarrier().
--
2.13.5
next prev parent reply other threads:[~2017-09-06 6:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 6:25 [PATCH 00/13] bcache: fixes and update for 4.14 Coly Li
2017-09-06 6:25 ` [PATCH 01/12] bcache: Fix leak of bdev reference Coly Li
2017-09-06 6:25 ` [PATCH 02/12] bcache: fix sequential large write IO bypass Coly Li
2017-09-06 6:25 ` [PATCH 03/12] bcache: do not subtract sectors_to_gc for bypassed IO Coly Li
2017-09-06 6:25 ` [PATCH 04/12] bcache: Don't reinvent the wheel but use existing llist API Coly Li
2017-09-26 4:38 ` Michael Lyle
2017-09-26 6:39 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
2017-09-26 7:09 ` Coly Li
2017-09-26 7:15 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
2017-09-26 7:22 ` Coly Li
2017-09-26 7:08 ` Coly Li
2017-09-26 7:16 ` 박병철/선임연구원/SW Platform(연)AOT팀(byungchul.park@lge.com)
2017-09-26 7:24 ` Coly Li
2017-09-26 7:46 ` Coly Li
2017-09-26 19:55 ` Michael Lyle
2017-09-06 6:25 ` [PATCH 05/12] bcache: gc does not work when triggering by manual command Coly Li
2017-09-06 6:25 ` [PATCH 06/12] bcache: correct cache_dirty_target in __update_writeback_rate() Coly Li
2017-09-06 6:25 ` [PATCH 07/12] bcache: Correct return value for sysfs attach errors Coly Li
2017-09-06 6:25 ` [PATCH 08/12] bcache: increase the number of open buckets Coly Li
2017-09-06 6:25 ` [PATCH 09/12] bcache: fix for gc and write-back race Coly Li
2017-09-06 6:26 ` [PATCH 10/12] bcache: silence static checker warning Coly Li
2017-09-06 6:26 ` Coly Li [this message]
2017-09-06 6:26 ` [PATCH 12/12] bcache: fix bch_hprint crash and improve output Coly Li
2017-09-06 14:20 ` [PATCH 00/13] bcache: fixes and update for 4.14 Jens Axboe
2017-09-06 15:41 ` Coly Li
2017-09-06 15:46 ` Jens Axboe
2017-09-06 17:38 ` Coly Li
2017-09-07 18:51 ` Eddie Chapman
2017-09-07 19:31 ` Jens Axboe
2017-09-07 19:01 ` Eddie Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170906062602.50497-12-colyli@suse.de \
--to=colyli@suse.de \
--cc=axboe@kernel.dk \
--cc=bcache@lists.ewheeler.net \
--cc=dan.carpenter@oracle.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox