From: Kai Krakow <hurikhan77@gmail.com>
To: linux-bcache@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] bcache: Fix building error on MIPS
Date: Thu, 16 Nov 2017 17:58:16 +0100 [thread overview]
Message-ID: <20171116175816.461480be@jupiter.sol.kaishome.de> (raw)
In-Reply-To: 1510801573-17878-1-git-send-email-chenhc@lemote.com
Am Thu, 16 Nov 2017 11:06:13 +0800
schrieb Huacai Chen <chenhc@lemote.com>:
> diff --git a/include/uapi/linux/bcache.h b/include/uapi/linux/bcache.h
> index 90fc490..5cc599c 100644
> --- a/include/uapi/linux/bcache.h
> +++ b/include/uapi/linux/bcache.h
> @@ -91,7 +91,7 @@ PTR_FIELD(PTR_GEN, 0, 8)
>
> #define PTR_CHECK_DEV ((1 << PTR_DEV_BITS) -
> 1)
> -#define PTR(gen, offset,
> dev) \ +#define
> MAKE_PTR(gen, offset,
> dev) \ ((((__u64) dev)
> << 51) | ((__u64) offset) << 8 | gen) /* Bkey utility code */
I don't think you make it any better by calling it MAKE_PTR then. How's
the next guy stumbling across such a conflict calling his definition
then? CREATE_PTR?
Why not call it BCH_PTR or similar?
--
Regards,
Kai
Replies to list-only preferred.
prev parent reply other threads:[~2017-11-16 16:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-16 3:06 [PATCH] bcache: Fix building error on MIPS Huacai Chen
2017-11-16 4:25 ` Coly Li
2017-11-16 4:29 ` 陈华才
2017-11-16 4:43 ` Michael Lyle
2017-11-16 16:58 ` Kai Krakow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116175816.461480be@jupiter.sol.kaishome.de \
--to=hurikhan77@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox