From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alasdair G Kergon Subject: Re: [PATCH 4/4] dm: convert table_device.count from atomic_t to refcount_t Date: Fri, 24 Nov 2017 14:04:13 +0000 Message-ID: <20171124140413.GG5952@agk-dp.fab.redhat.com> References: <1508485059-21881-1-git-send-email-elena.reshetova@intel.com> <1508485059-21881-5-git-send-email-elena.reshetova@intel.com> <92f8c04f-ef1a-c41b-e82f-8d68a3ec84b5@redhat.com> <2236FBA76BA1254E88B949DDB74E612B802C1F4D@IRSMSX102.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <2236FBA76BA1254E88B949DDB74E612B802C1F4D@IRSMSX102.ger.corp.intel.com> Sender: linux-raid-owner@vger.kernel.org To: "Reshetova, Elena" Cc: Zdenek Kabelac , "dm-devel@redhat.com" , "linux-bcache@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-raid@vger.kernel.org" , "kent.overstreet@gmail.com" , "koverstreet@google.com" , "ejt@redhat.com" , "snitzer@redhat.com" , "shli@kernel.org" , "agk@redhat.com" , "peterz@infradead.org" , "keescook@chromium.org" List-Id: linux-bcache@vger.kernel.org On Fri, Nov 24, 2017 at 08:29:42AM +0000, Reshetova, Elena wrote: > By looking at the code, I don't see where the change in the reference counting > could have caused this. The cause was the bug I identified in patch 3, not this patch. The regression is easily hit - tables that reference the same underlying device more than once are very common. Alasdair