From: Marc MERLIN <marc@merlins.org>
To: Pavel Goran <via-bcache@pvgoran.name>
Cc: linux-bcache@vger.kernel.org
Subject: Re: Bcache confirmed unsafe with 4.14.0? 4.14.1?
Date: Fri, 24 Nov 2017 08:29:56 -0800 [thread overview]
Message-ID: <20171124162956.slic7hvffpivhohp@merlins.org> (raw)
In-Reply-To: <788678673.20171124162253@pvgoran.name>
On Fri, Nov 24, 2017 at 04:22:53PM +0700, Pavel Goran wrote:
> Hello Marc,
>
> Friday, November 24, 2017, 2:41:12 PM, you wrote:
>
> > I have bcache | dmcrypt | btrfs, and I was upgrading to 4.14.0 when
> > someone told me about the corruption problems people noticed in 4.14.0
>
> > Is there an understood root cause and something to avoid to not trigger
> > the bug, or not so much?
>
> The bug was caused by a change in the block layer code (outside of bcache),
> commit 74d46992e0d9dee7f1f376de0d56d31614c8a17a, "block: replace bi_bdev with
> a gendisk pointer and partitions index". I don't know if there are any
> specific usage patterns that trigger the problem. I strongly suggest not to
> run the affected kernel versions on any machine that uses bcache (or, even
> better, on any machine at all).
>
> > I saw a bunch of patches go by and I'm not too clear if 4.14.1 is safe,
> > or not.
>
> In 4.14.1 (as published here
> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tag/?h=v4.14.1),
> this bug was not fixed yet. However, the very recent 4.14.2 does contain the
> fix (commit 62530ed8b1d07a45dec94d46e521c0c6c2d476e6, "bio: ensure
> __bio_clone_fast copies bi_partno").
Thanks for clearing that up, I duly appreciate it.
Marc
--
"A mouse is a device used to point at the xterm you want to type in" - A.S.R.
Microsoft is to operating systems ....
.... what McDonalds is to gourmet cooking
Home page: http://marc.merlins.org/ | PGP 1024R/763BE901
next prev parent reply other threads:[~2017-11-24 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-24 7:41 Bcache confirmed unsafe with 4.14.0? 4.14.1? Marc MERLIN
2017-11-24 9:22 ` Pavel Goran
2017-11-24 16:29 ` Marc MERLIN [this message]
2017-11-26 13:55 ` Justin Cinkelj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124162956.slic7hvffpivhohp@merlins.org \
--to=marc@merlins.org \
--cc=linux-bcache@vger.kernel.org \
--cc=via-bcache@pvgoran.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox