Re: [for-416 PATCH 1/2] bcache: Fix, improve efficiency of closure_sync()

Jens Axboe
2018-01-05T16:05:17Z

On 12/30/17 4:09 PM, Michael Lyle wrote:
> +void __closure_sync(struct closure *cl)
> +{
> + struct closure_syncer s = { .task = current };
>
> + cl->s = &s;
> + continue_at(cl, closure_sync_fn, NULL);
> +
> + while (1) {
> + __set_current_state(TASK_UNINTERRUPTIBLE);
> + smp_mb(); /* Ensure task state set before load of done flag */

That's why we have set_current_state().

--
Jens Axboe