From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, Boaz Harrosh <ooo@electrozaur.com>,
linux-bcache@vger.kernel.org, dm-devel@redhat.com,
Ming Lei <ming.lei@redhat.com>
Subject: [PATCH 2/6] bcache: don't clone bio in bch_data_verify
Date: Tue, 19 Jun 2018 06:52:12 +0200 [thread overview]
Message-ID: <20180619045216.21130-3-hch@lst.de> (raw)
In-Reply-To: <20180619045216.21130-1-hch@lst.de>
We immediately overwrite the biovec array, so instead just allocate
a new bio and copy over the disk, setor and size.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
drivers/md/bcache/debug.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/md/bcache/debug.c b/drivers/md/bcache/debug.c
index d030ce3025a6..04d146711950 100644
--- a/drivers/md/bcache/debug.c
+++ b/drivers/md/bcache/debug.c
@@ -110,11 +110,15 @@ void bch_data_verify(struct cached_dev *dc, struct bio *bio)
struct bio_vec bv, cbv;
struct bvec_iter iter, citer = { 0 };
- check = bio_clone_kmalloc(bio, GFP_NOIO);
+ check = bio_kmalloc(GFP_NOIO, bio_segments(bio));
if (!check)
return;
+ check->bi_disk = bio->bi_disk;
check->bi_opf = REQ_OP_READ;
+ check->bi_iter.bi_sector = bio->bi_iter.bi_sector;
+ check->bi_iter.bi_size = bio->bi_iter.bi_size;
+ bch_bio_map(check, NULL);
if (bch_bio_alloc_pages(check, GFP_NOIO))
goto out_put;
--
2.17.1
next prev parent reply other threads:[~2018-06-19 4:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 4:52 [RFC] kill bio_clone_kmalloc and bio_clone_bioset Christoph Hellwig
2018-06-19 4:52 ` [PATCH 1/6] dm: use bio_split() when splitting out the already processed bio Christoph Hellwig
2018-06-19 4:52 ` Christoph Hellwig [this message]
2018-06-19 7:41 ` [PATCH 2/6] bcache: don't clone bio in bch_data_verify Coly Li
2018-06-19 4:52 ` [PATCH 3/6] exofs: use bio_clone_fast in _write_mirror Christoph Hellwig
2018-06-19 7:54 ` Boaz Harrosh
2018-06-19 4:52 ` [PATCH 4/6] block: remove bio_clone_kmalloc Christoph Hellwig
2018-06-19 4:52 ` [PATCH 5/6] md: remove a bogus comment Christoph Hellwig
2018-06-19 4:52 ` [PATCH 6/6] block: unexport bio_clone_bioset Christoph Hellwig
2018-06-20 9:12 ` [RFC] kill bio_clone_kmalloc and bio_clone_bioset Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180619045216.21130-3-hch@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=ooo@electrozaur.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).