From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Damien Le Moal <Damien.LeMoal@wdc.com>,
"linux-btrace@vger.kernel.org" <linux-btrace@vger.kernel.org>,
"bvanassche@acm.org" <bvanassche@acm.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
"yuchao0@huawei.com" <yuchao0@huawei.com>,
"colyli@suse.de" <colyli@suse.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-bcache@vger.kernel.org" <linux-bcache@vger.kernel.org>,
Minwoo Im <minwoo.im.dev@gmail.com>,
"jaegeuk@kernel.org" <jaegeuk@kernel.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"kent.overstreet@gmail.com" <kent.overstreet@gmail.com>,
"roger.pau@citrix.com" <roger.pau@citrix.com>
Subject: Re: [PATCH V3 4/9] blk-zoned: update blkdev_reset_zones() with helper
Date: Wed, 3 Jul 2019 14:25:28 +0900 [thread overview]
Message-ID: <20190703052528.GB21258@minwoo-desktop> (raw)
In-Reply-To: <DM6PR04MB5754D27FC41D86E2D419DD6C86FB0@DM6PR04MB5754.namprd04.prod.outlook.com>
On 19-07-03 02:29:33, Chaitanya Kulkarni wrote:
> On 7/2/19 5:23 PM, Minwoo Im wrote:
> > On 19-07-02 10:42:30, Chaitanya Kulkarni wrote:
> >> This patch updates the blkdev_reset_zones() with newly introduced
> >> helper function to read the nr_sects from block device's hd_parts with
> >> the help of part_nr_sects_read().
> > Chaitanya,
> >
> > Are the first three patches split for a special reason? IMHO, it could
> > be squashed into a single one.
> >
> > It looks good to me, by the way.
>
> In the blk-zoned.c in this way it is easier to bisect if/when the problem
>
> comes.
Oh okay. That makes sense.
Thanks, Chaitanya.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-03 5:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 17:42 [PATCH V3 0/9] block: use right accessor to read nr_sects Chaitanya Kulkarni
2019-07-02 17:42 ` [PATCH V3 1/9] block: add a helper function to read nr_setcs Chaitanya Kulkarni
2019-07-03 0:19 ` Minwoo Im
2019-07-03 15:03 ` Bart Van Assche
2019-07-04 0:11 ` Chaitanya Kulkarni
2019-07-02 17:42 ` [PATCH V3 2/9] blk-zoned: update blkdev_nr_zones() with helper Chaitanya Kulkarni
2019-07-03 0:20 ` Minwoo Im
2019-07-02 17:42 ` [PATCH V3 3/9] blk-zoned: update blkdev_report_zone() " Chaitanya Kulkarni
2019-07-03 0:21 ` Minwoo Im
2019-07-02 17:42 ` [PATCH V3 4/9] blk-zoned: update blkdev_reset_zones() " Chaitanya Kulkarni
2019-07-03 0:23 ` Minwoo Im
2019-07-03 2:29 ` Chaitanya Kulkarni
2019-07-03 5:25 ` Minwoo Im [this message]
2019-07-02 17:42 ` [PATCH V3 5/9] bcache: update cached_dev_init() " Chaitanya Kulkarni
2019-07-02 17:42 ` [PATCH V3 6/9] f2fs: use helper in init_blkz_info() Chaitanya Kulkarni
2019-07-02 17:42 ` [PATCH V3 7/9] blktrace: use helper in blk_trace_setup_lba() Chaitanya Kulkarni
2019-07-02 17:42 ` [COMPILE TEST ONLY PATCH V3 8/9] target/pscsi: use helper in pscsi_get_blocks() Chaitanya Kulkarni
2019-07-02 17:42 ` [COMPILE TEST ONLY PATCH V3 9/9] xen/blkback: use helper in vbd_sz() Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703052528.GB21258@minwoo-desktop \
--to=minwoo.im.dev@gmail.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Damien.LeMoal@wdc.com \
--cc=bvanassche@acm.org \
--cc=colyli@suse.de \
--cc=jaegeuk@kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrace@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox