From mboxrd@z Thu Jan 1 00:00:00 1970 From: colyli@suse.de Subject: [PATCH 01/17] bcache: cached_dev_free needs to put the sb page Date: Fri, 24 Jan 2020 01:01:26 +0800 Message-ID: <20200123170142.98974-2-colyli@suse.de> References: <20200123170142.98974-1-colyli@suse.de> Return-path: Received: from mx2.suse.de ([195.135.220.15]:51212 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728899AbgAWRCD (ORCPT ); Thu, 23 Jan 2020 12:02:03 -0500 In-Reply-To: <20200123170142.98974-1-colyli@suse.de> Sender: linux-bcache-owner@vger.kernel.org List-Id: linux-bcache@vger.kernel.org To: axboe@kernel.dk Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org, Liang Chen , Christoph Hellwig , Coly Li From: Liang Chen Same as cache device, the buffer page needs to be put while freeing cached_dev. Otherwise a page would be leaked every time a cached_dev is stopped. Signed-off-by: Liang Chen Signed-off-by: Christoph Hellwig Signed-off-by: Coly Li --- drivers/md/bcache/super.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 77e9869345e7..a573ce1d85aa 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1275,6 +1275,9 @@ static void cached_dev_free(struct closure *cl) mutex_unlock(&bch_register_lock); + if (dc->sb_bio.bi_inline_vecs[0].bv_page) + put_page(bio_first_page_all(&dc->sb_bio)); + if (!IS_ERR_OR_NULL(dc->bdev)) blkdev_put(dc->bdev, FMODE_READ|FMODE_WRITE|FMODE_EXCL); -- 2.16.4