[PATCH v2 00/17] bcache: extend bucket size to 32bit width

Coly Li
2020-07-15T05:46:21Z

This patch series is an effort to extent bucket_size from 16bit to
32bit width. This is the code base for next step to use zoned device as
cache device.

In this series, these changes should be noticed,
- Increase the super block version to
BCACHE_SB_VERSION_CDEV_WITH_FEATURES 5
BCACHE_SB_VERSION_BDEV_WITH_FEATURES 6
- The new version adds 3 new members,
__le64 feature_compat;
__le64 feature_incompat;
__le64 feature_ro_compat;
If new feature added will change the on-disk format, just setting the
feature set bits, no need to upstream super block version.
- The in-memory struct cache_sb does not exactly map the on-disk struct
cache_sb_disk.
- Add 32bit bucket_size_hi in struct cache_sb_disk,
__le32 bucket_size_hi;
In theory bucket_size can be extended to 48bit, but now 32bit width is
big enough.
- Other changes to follow the large bucket size.

The changes are mostly on cache device, except the super block update
there is no change about the backing device.

Any code review comments or suggestion is welcome. Thanks in advance.

Coly Li
---
Changelog:
v2: several bug fixes, and add sysfs file to display cache set feature
sets information.
v1: initial RFC version.

Coly Li (17):
bcache: add comments to mark member offset of struct cache_sb_disk
bcache: add read_super_basic() to read major part of super block
bcache: add more accurate error information in read_super_basic()
bcache: disassemble the big if() checks in bch_cache_set_alloc()
bcache: fix super block seq numbers comparision in
register_cache_set()
bcache: increase super block version for cache device and backing
device
bcache: move bucket related code into read_super_basic()
bcache: struct cache_sb is only for in-memory super block now
bcache: introduce meta_bucket_pages() related helper routines
bcache: handle c->uuids properly for bucket size > 8MB
bcache: handle cache prio_buckets and disk_buckets properly for bucket
size > 8MB
bcache: handle cache set verify_ondisk properly for bucket size > 8MB
bcache: handle btree node memory allocation properly for bucket size >
8MB
bcache: add bucket_size_hi into struct cache_sb_disk for large bucket
bcache: add sysfs file to display feature sets information of cache
set
bcache: avoid extra memory allocation from mempool c->fill_iter
bcache: avoid extra memory consumption in struct bbio for large bucket
size

drivers/md/bcache/Makefile | 2 +-
drivers/md/bcache/alloc.c | 2 +-
drivers/md/bcache/bcache.h | 29 +++-
drivers/md/bcache/btree.c | 12 +-
drivers/md/bcache/features.c | 70 ++++++++++
drivers/md/bcache/features.h | 84 +++++++++++
drivers/md/bcache/io.c | 2 +-
drivers/md/bcache/movinggc.c | 4 +-
drivers/md/bcache/super.c | 261 ++++++++++++++++++++++++-----------
drivers/md/bcache/sysfs.c | 6 +
include/uapi/linux/bcache.h | 75 ++++++----
11 files changed, 426 insertions(+), 121 deletions(-)
create mode 100644 drivers/md/bcache/features.c
create mode 100644 drivers/md/bcache/features.h

--
2.26.2