From: Christoph Hellwig <hch@infradead.org>
To: Dongsheng Yang <dongsheng.yang@easystack.cn>
Cc: colyli@suse.de, linux-bcache@vger.kernel.org,
linux-kernel@vger.kernel.org, mchristi@redhat.com
Subject: Re: [PATCH] bcache: dont reset bio opf in bch_data_insert_start
Date: Wed, 27 Jan 2021 17:37:26 +0000 [thread overview]
Message-ID: <20210127173726.GA1738577@infradead.org> (raw)
In-Reply-To: <20210125042942.1087170-1-dongsheng.yang@easystack.cn>
But the old code is also completely broken. We can't just OR in
the op, as that implicitly assumes the old op was 0 (REQ_OP_READ).
Please fix this to explicitly set the exact op and flags that you want
instead of this fragile magic.
next prev parent reply other threads:[~2021-01-27 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-25 4:29 [PATCH] bcache: dont reset bio opf in bch_data_insert_start Dongsheng Yang
2021-01-25 4:53 ` Coly Li
2021-01-26 4:32 ` Dongsheng Yang
2021-01-26 4:34 ` Coly Li
2021-01-26 4:41 ` Dongsheng Yang
2021-01-27 17:37 ` Christoph Hellwig [this message]
2021-01-28 9:10 ` Dongsheng Yang
2021-01-28 10:45 ` Dongsheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127173726.GA1738577@infradead.org \
--to=hch@infradead.org \
--cc=colyli@suse.de \
--cc=dongsheng.yang@easystack.cn \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchristi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox