From: Christoph Hellwig <hch@lst.de>
To: Coly Li <colyli@suse.de>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
snitzer@kernel.org, Song Liu <song@kernel.org>,
linux-block@vger.kernel.org,
linux-raid <linux-raid@vger.kernel.org>,
linux-bcache@vger.kernel.org, dm-devel@redhat.com
Subject: Re: [PATCH] block: remove bio_set_op_attrs
Date: Tue, 6 Dec 2022 15:49:02 +0100 [thread overview]
Message-ID: <20221206144902.GA31845@lst.de> (raw)
In-Reply-To: <434E4CE3-EA46-4CD9-9EAF-5C1B99B8A603@suse.de>
On Tue, Dec 06, 2022 at 10:46:31PM +0800, Coly Li wrote:
> BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it was added to avoid open code, and now we remove it to use open coded assignments. What is the motivation for now?
It was added when the flags encoding was a mess. Now that the RQF_
flags are split out things have become much simpler and we don't need
to hide a simple assignment of a value to a field.
next prev parent reply other threads:[~2022-12-06 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 14:40 [PATCH] block: remove bio_set_op_attrs Christoph Hellwig
2022-12-06 14:46 ` Coly Li
2022-12-06 14:49 ` Christoph Hellwig [this message]
2022-12-06 14:51 ` [dm-devel] " Coly Li
2022-12-06 18:55 ` Bart Van Assche
2022-12-07 9:26 ` Johannes Thumshirn
2022-12-07 16:43 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221206144902.GA31845@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=colyli@suse.de \
--cc=dm-devel@redhat.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox