From: Chaitanya Kulkarni <kch@nvidia.com>
To: <linux-block@vger.kernel.org>, <linux-bcache@vger.kernel.org>
Cc: <axboe@kernel.dk>, <josef@toxicpanda.com>, <minchan@kernel.org>,
<senozhatsky@chromium.org>, <colyli@suse.de>,
<kent.overstreet@gmail.com>, <dlemoal@kernel.org>,
<kch@nvidia.com>, <johannes.thumshirn@wdc.com>,
<bvanassche@acm.org>, <vincent.fu@samsung.com>,
<akinobu.mita@gmail.com>, <shinichiro.kawasaki@wdc.com>,
<nbd@other.debian.org>
Subject: [PATCH 2/5] brd: don't clear the flag that is not set
Date: Mon, 24 Apr 2023 00:30:20 -0700 [thread overview]
Message-ID: <20230424073023.38935-3-kch@nvidia.com> (raw)
In-Reply-To: <20230424073023.38935-1-kch@nvidia.com>
QUEUE_FLAG_ADD_RANDOM is not set in brd_alloc() before we clear it.
There is no point in clearing the flag that is not set.
Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM.
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
---
drivers/block/brd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/block/brd.c b/drivers/block/brd.c
index 34177f1bd97d..bcad9b926b0c 100644
--- a/drivers/block/brd.c
+++ b/drivers/block/brd.c
@@ -404,7 +404,6 @@ static int brd_alloc(int i)
/* Tell the block layer that this is not a rotational device */
blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, disk->queue);
- blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
blk_queue_flag_set(QUEUE_FLAG_NOWAIT, disk->queue);
err = add_disk(disk);
if (err)
--
2.40.0
next prev parent reply other threads:[~2023-04-24 7:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230424092940epcas5p3407002e7d5c79593ffbafc38f2b49e51@epcas5p3.samsung.com>
2023-04-24 7:30 ` [PATCH 0/5] block/drivers: don't clear the flag that is not set Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 1/5] null_blk: " Chaitanya Kulkarni
2023-04-24 7:30 ` Chaitanya Kulkarni [this message]
2023-04-24 7:30 ` [PATCH 3/5] nbd: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 4/5] zram: " Chaitanya Kulkarni
2023-04-24 7:30 ` [PATCH 5/5] bcache: " Chaitanya Kulkarni
2023-04-24 10:19 ` [PATCH 5/5] bcache: don't clear the flag that is not set^[ Coly Li
2023-04-24 9:26 ` [PATCH 0/5] block/drivers: don't clear the flag that is not set Nitesh Shetty
2023-04-24 10:25 ` Chaitanya Kulkarni
2023-04-24 10:40 ` Nitesh Shetty
2023-04-24 16:39 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230424073023.38935-3-kch@nvidia.com \
--to=kch@nvidia.com \
--cc=akinobu.mita@gmail.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=colyli@suse.de \
--cc=dlemoal@kernel.org \
--cc=johannes.thumshirn@wdc.com \
--cc=josef@toxicpanda.com \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=nbd@other.debian.org \
--cc=senozhatsky@chromium.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox