Re: [PATCH] Separate bch_moving_gc() from bch_btree_gc()

[kernel test robot <lkp@intel.com>]

Hi Mingzhe,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.4 next-20230627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mingzhe-Zou/Separate-bch_moving_gc-from-bch_btree_gc/20230627-172221
base:   linus/master
patch link:    https://lore.kernel.org/r/20230627092122.197-1-mingzhe.zou%40easystack.cn
patch subject: [PATCH] Separate bch_moving_gc() from bch_btree_gc()
config: powerpc-randconfig-r012-20230627 (https://download.01.org/0day-ci/archive/20230627/202306272212.276Fkm0f-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce: (https://download.01.org/0day-ci/archive/20230627/202306272212.276Fkm0f-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306272212.276Fkm0f-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/md/bcache/btree.c:1839:27: error: use of undeclared identifier 'bch_cutoff_writeback_sync'
    1839 |         if (c->gc_stats.in_use > bch_cutoff_writeback_sync)
         |                                  ^
>> drivers/md/bcache/btree.c:1843:18: error: use of undeclared identifier 'b'
    1843 |         for_each_bucket(b, ca) {
         |                         ^
>> drivers/md/bcache/btree.c:1843:18: error: use of undeclared identifier 'b'
>> drivers/md/bcache/btree.c:1843:18: error: use of undeclared identifier 'b'
   drivers/md/bcache/btree.c:1844:15: error: use of undeclared identifier 'b'
    1844 |                 if (GC_MARK(b) != GC_MARK_DIRTY)
         |                             ^
   drivers/md/bcache/btree.c:1849:34: error: use of undeclared identifier 'b'
    1849 |                 used_sectors = GC_SECTORS_USED(b);
         |                                                ^
>> drivers/md/bcache/btree.c:1862:78: error: expected ';' after expression
    1862 |         frag_percent = div_u64(frag_sectors * 100, ca->sb.bucket_size * c->nbuckets)
         |                                                                                     ^
         |                                                                                     ;
   7 errors generated.


vim +/bch_cutoff_writeback_sync +1839 drivers/md/bcache/btree.c

  1831	
  1832	static bool moving_gc_should_run(struct cache_set *c)
  1833	{
  1834		struct cache *ca = c->cache;
  1835		size_t moving_gc_threshold = ca->sb.bucket_size >> 2, frag_percent;
  1836		unsigned long used_buckets = 0, frag_buckets = 0, move_buckets = 0;
  1837		unsigned long dirty_sectors = 0, frag_sectors, used_sectors;
  1838	
> 1839		if (c->gc_stats.in_use > bch_cutoff_writeback_sync)
  1840			return true;
  1841	
  1842		mutex_lock(&c->bucket_lock);
> 1843		for_each_bucket(b, ca) {
  1844			if (GC_MARK(b) != GC_MARK_DIRTY)
  1845				continue;
  1846	
  1847			used_buckets++;
  1848	
  1849			used_sectors = GC_SECTORS_USED(b);
  1850			dirty_sectors += used_sectors;
  1851	
  1852			if (used_sectors < ca->sb.bucket_size)
  1853				frag_buckets++;
  1854	
  1855			if (used_sectors <= moving_gc_threshold)
  1856				move_buckets++;
  1857		}
  1858		mutex_unlock(&c->bucket_lock);
  1859	
  1860		c->fragment_nbuckets = frag_buckets;
  1861		frag_sectors = used_buckets * ca->sb.bucket_size - dirty_sectors;
> 1862		frag_percent = div_u64(frag_sectors * 100, ca->sb.bucket_size * c->nbuckets)
  1863	
  1864		if (move_buckets > ca->heap.size)
  1865			return true;
  1866	
  1867		if (frag_percent >= COPY_GC_PERCENT)
  1868			return true;
  1869	
  1870		return false;
  1871	}
  1872	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki