* [PATCH][next] bcache: remove redundant assignment to variable cur_idx
@ 2023-07-25 11:46 Colin Ian King
2023-07-25 12:49 ` Coly Li
0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2023-07-25 11:46 UTC (permalink / raw)
To: Coly Li, Kent Overstreet, linux-bcache; +Cc: kernel-janitors, linux-kernel
Variable cur_idx is being initialized with a value that is never read,
it is being re-assigned later in a while-loop. Remove the redundant
assignment. Cleans up clang scan build warning:
drivers/md/bcache/writeback.c:916:2: warning: Value stored to 'cur_idx'
is never read [deadcode.DeadStores]
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/md/bcache/writeback.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
index 24c049067f61..c3e872e0a6f2 100644
--- a/drivers/md/bcache/writeback.c
+++ b/drivers/md/bcache/writeback.c
@@ -913,7 +913,7 @@ static int bch_dirty_init_thread(void *arg)
int cur_idx, prev_idx, skip_nr;
k = p = NULL;
- cur_idx = prev_idx = 0;
+ prev_idx = 0;
bch_btree_iter_init(&c->root->keys, &iter, NULL);
k = bch_btree_iter_next_filter(&iter, &c->root->keys, bch_ptr_bad);
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] bcache: remove redundant assignment to variable cur_idx
2023-07-25 11:46 [PATCH][next] bcache: remove redundant assignment to variable cur_idx Colin Ian King
@ 2023-07-25 12:49 ` Coly Li
0 siblings, 0 replies; 2+ messages in thread
From: Coly Li @ 2023-07-25 12:49 UTC (permalink / raw)
To: Colin Ian King
Cc: Kent Overstreet, Bcache Linux, kernel-janitors, linux-kernel
> 2023年7月25日 19:46，Colin Ian King <colin.i.king@gmail.com> 写道：
>
> Variable cur_idx is being initialized with a value that is never read,
> it is being re-assigned later in a while-loop. Remove the redundant
> assignment. Cleans up clang scan build warning:
>
> drivers/md/bcache/writeback.c:916:2: warning: Value stored to 'cur_idx'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Looks good to me. Thanks.
Reviewed-by: Coly Li <colyli@suse.de>
Coly Li
> ---
> drivers/md/bcache/writeback.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 24c049067f61..c3e872e0a6f2 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -913,7 +913,7 @@ static int bch_dirty_init_thread(void *arg)
> int cur_idx, prev_idx, skip_nr;
>
> k = p = NULL;
> - cur_idx = prev_idx = 0;
> + prev_idx = 0;
>
> bch_btree_iter_init(&c->root->keys, &iter, NULL);
> k = bch_btree_iter_next_filter(&iter, &c->root->keys, bch_ptr_bad);
> --
> 2.39.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-25 12:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-25 11:46 [PATCH][next] bcache: remove redundant assignment to variable cur_idx Colin Ian King
2023-07-25 12:49 ` Coly Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).