From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B77F742AB2; Tue, 28 Nov 2023 21:09:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ALWzZdCz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1719C433B8; Tue, 28 Nov 2023 21:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701205764; bh=OK76i06rqZHu7OVaftPcgvmDgd5Tpkk1MQpp8bUEU0M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ALWzZdCzDrX8W/XYI3ki1n5ovazvM0pdhom7bFyraduamslm+AemjMlWXPejNs+Na 6QO0NM51LCCv15jKLe5x1jaYnE1n1MDVWcZt0wh6L504X/hOQjZ7+iSXSCM4y2Aw6l xRy6fBCRMrEI0k37CF1T/iI8s6fCDmKJZBsap97hr0BjXcotL3RmStK4kANZtAI/PM 35DFsGIo44yGTdRQhRaKgb2bQZk2zUto0Av2eS7XdQDr8XZHvJoQVRzesvxaGXHJ23 kimqQll2J9u7/QcX0Pwi4fZidHd9Ceg/RkAQ/3+DQvEf5hXeU8s/d23d5ThXDJUbsX LK+7ujHt/59qA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Coly Li , Jens Axboe , Sasha Levin , kent.overstreet@gmail.com, linux-bcache@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 06/13] bcache: avoid NULL checking to c->root in run_cache_set() Date: Tue, 28 Nov 2023 16:09:00 -0500 Message-ID: <20231128210914.876813-6-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231128210914.876813-1-sashal@kernel.org> References: <20231128210914.876813-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-bcache@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.202 Content-Transfer-Encoding: 8bit From: Coly Li [ Upstream commit 3eba5e0b2422aec3c9e79822029599961fdcab97 ] In run_cache_set() after c->root returned from bch_btree_node_get(), it is checked by IS_ERR_OR_NULL(). Indeed it is unncessary to check NULL because bch_btree_node_get() will not return NULL pointer to caller. This patch replaces IS_ERR_OR_NULL() by IS_ERR() for the above reason. Signed-off-by: Coly Li Link: https://lore.kernel.org/r/20231120052503.6122-11-colyli@suse.de Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/md/bcache/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index 9c3e1632568c3..04ddaa4bbd77f 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -2043,7 +2043,7 @@ static int run_cache_set(struct cache_set *c) c->root = bch_btree_node_get(c, NULL, k, j->btree_level, true, NULL); - if (IS_ERR_OR_NULL(c->root)) + if (IS_ERR(c->root)) goto err; list_del_init(&c->root->list); -- 2.42.0